891491 - Implement i18n-abide on Webmaker.org

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Ali Al Dallal [:alicoding]]

We want to start off a bug that only does the implementation of the i18n-abide setup first.

Comment 1

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/webmaker.org/pull/252

In this pull request I haven't include the `locale` directory in it, and only enabled the default language to `en-US` with one supported language which is also `en-US`.

I believe if this is going to be landed it wouldn't be notice and not going to affect any of the behaviour of the site IMO.

Comment 2

[Ali Al Dallal [:alicoding]]

To avoid some merge conflict I have update the PR with added the locale/en_US/messages.plist with most of the text that is going to be the same with most of the  tickets that I filed.

Comment 3

[Matthew Schranz [:mjschranz]]

Comment on attachment 773293 [details] [review]
https://github.com/mozilla/webmaker.org/pull/252

I can't run the server locally.

Comment 4

[Matthew Schranz [:mjschranz]]

Specifically, this appears when running npm install

npm ERR! Failed resolving git HEAD (git://github.com/humphd/i18n-abide.git) fatal: bad object fc932caa42a4cfa88161dfe1a27e88085e85e3bd
npm ERR! Failed resolving git HEAD (git://github.com/humphd/i18n-abide.git) 
npm ERR! Error: `git "rev-list" "-n1" "fc932caa42a4cfa88161dfe1a27e88085e85e3bd"` failed with 128
npm ERR!     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/exec.js:59:20)
npm ERR!     at ChildProcess.EventEmitter.emit (events.js:98:17)
npm ERR!     at maybeClose (child_process.js:730:16)
npm ERR!     at Socket.<anonymous> (child_process.js:943:11)
npm ERR!     at Socket.EventEmitter.emit (events.js:95:17)
npm ERR!     at Pipe.close (net.js:451:12)
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR!     <[e-mail]>

Comment 5

[Matthew Schranz [:mjschranz]]

Comment on attachment 773293 [details] [review]
https://github.com/mozilla/webmaker.org/pull/252

Recent updates have fixed this so I'm fine with this landing.

Let humph review this though before landing.

Comment 6

[David Humphrey (:humph)]

Comment on attachment 773293 [details] [review]
https://github.com/mozilla/webmaker.org/pull/252

A few things in the PR.

Flagging Jon for additional review, not because of the code, but because of the cost of landing this.  We need to figure out our strategy about when to do it.  I think it's fine, but it would be good to test it carefully on staging before we roll it out.  Jon, also note there are a bunch more bugs that will do things after this to localize all the rest of the site.  So landing those in succession would be good, too.

Comment 7

[Ali Al Dallal [:alicoding]]

I'm thinking that I should remove the content in the .plist file from this bug because it is a duplicate content and work from another bug. Also it is hard to change anything from this PR because I can't refer to the actual page at all.

Comment 8

[Jon Buckley [:jbuck]]

Comment on attachment 773293 [details] [review]
https://github.com/mozilla/webmaker.org/pull/252

Looks good, just need to move the i18n-abide block below the express.static block.

Comment 9

[Ali Al Dallal [:alicoding]]

Comment on attachment 773293 [details] [review]
https://github.com/mozilla/webmaker.org/pull/252

So I have upgraded the i18n-abide to be able to use .json file and I also did the change the :jbuck asked in the PR.

:humph I didn't have any string inside the messages.json at all because I thought it is better to do it in other tickets.

Comment 10

[Jon Buckley [:jbuck]]

Comment on attachment 773293 [details] [review]
https://github.com/mozilla/webmaker.org/pull/252

Looks good to me. Are there any bugs that have translations ready? I'd wait to land this until atleast 1-2 of them are ready.

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/da0900322732d5f5c09925cdcddc50240769d1ab
bug891491 - Implement i18n-abide on Webmaker.org