89162 - Single-signon can't observe profile change if no instances exist

Status: VERIFIED FIXED

(SeaMonkey :: Passwords & Permissions, defect, P1)

Description

[Conrad Carlen (not reading bugmail)]

This was going to be checked in with bug 86021 but that's no longer going into
the branch. This needs to for the sake of embedding clients using profile
switching. The problem is this: nsISingleSignon observes profile changes. Since
these are components and not a service, if the last instance is destroyed before
switching the profile (typical) there's nothing to observe the change and signon
data is not flushed. I'm not sure why this was never noticed before. Maybe we
were leaking a signon.

Comment 1

[Alec Flett]

we should use app-startup components to instantiate a profile change listener...

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: patch to make the observer static

Comment 3

[Conrad Carlen (not reading bugmail)]

Alec, this is the same patch that you sr'd before with changes from your
comments. The static member var is no longer an nsIObserver* but a simple
PR_Bool and it's commented a bit better. Can you sr= this one? Steve, can you r=?

Comment 4

[Conrad Carlen (not reading bugmail)]

Alec, I didn't see your comment before posting that patch.
> we should use app-startup components
I like that idea. On the other hand, this patch is tested and ready.

Comment 5

[Alec Flett]

works for me!
sr=alecf

Comment 6

[Stephen P. Morse]

Sorry, Steve's on vacation this week.  But I approve your making this change to 
the wallet module.  But you'll need to get someone else to do the review if you 
want it done this week.

Comment 7

[Judson Valeski]

r=valeski

Comment 8

[Judson Valeski]

let's get this into the branch and trunk.

Comment 9

[Conrad Carlen (not reading bugmail)]

Fix checked into branch & trunk.

Comment 10

[Terri Preston]

Verified fix checked into lxr.mozilla.org