892341 - sdk/console/plain-text leaks

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: screen shot

I made an add-on with a blank main.js and it appears that the sdk/console/plain-text module is leaking.  See the attached screen shot, it was taken after forcing a gc multiple times.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1094

Pointer to Github pull-request

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 773779 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1094

Thanks!

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3aa505d198fb7ffef0abdec23863583ec48e5d09
Bug 892341 sdk/console/plain-text leaks, use a weak ref instead of a strong ref

https://github.com/mozilla/addon-sdk/commit/1cc54b179442abb4e575b03d1909ee3d36bfa84d
Merge pull request #1094 from erikvold/892341

Bug 892341 sdk/console/plain-text leaks, use a weak ref instead of a strong ref r=@gozala

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

This should be uplifted imo, because every 1.14 jetpack in existence is leaking due to the leak patched here.

Comment 6

[Dave Townsend [:mossop]]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #5)
> This should be uplifted imo, because every 1.14 jetpack in existence is
> leaking due to the leak patched here.

What kind of a leak are we talking about here. Does it only leak if the add-on is disabled at runtime? Does the leak grow in size over time?