892491 - [AccessFu] Add quick navigation item for landmarks

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Now that we utter landmarks, we should also add an item to the quick navigation system to allow the user to jump from landmark to landmark.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: [AccessFu] Add landmark quick navigation,

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 774068 [details] [diff] [review]
[AccessFu] Add landmark quick navigation,

Review of attachment 774068 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. We really need to fix the pivot API so it were more container friendly. But overall, great.

::: accessible/src/jsat/Utils.jsm
@@ +261,5 @@
>  
>      return true;
> +  },
> +
> +  gLandmarks: [

This should just be a const member of getLandmarkName.

Comment 3

[Marco Zehe (:MarcoZ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df5a4a4a99ee

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df5a4a4a99ee