892876 - AUDIO IN/OUT enums are different between gecko and jb audio

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[vasanth]

Attachment: Updating AUDIO IN OUT enums similar to jb

Comparing [1] and [2], shows AUDIO OUT/IN enum values are changed in jb but not yet updated in gecko.
This causes FM in jb to use wrong audio output path and fails to play.

Attached patch fixes this issue.


[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/android_audio/AudioSystem.h#256

[2] https://git.quicinc.com/?p=platform/system/core.git;a=blob;f=include/system/audio.h;h=8e5443066234307e29f562eacf9eba49afbe5ac9;hb=refs/heads/jb_mr1-stable#l357

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Looks like [2] is an invalid URL, can you please provide one that works?

Comment 2

[vasanth]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #1)
> Looks like [2] is an invalid URL, can you please provide one that works?

Sorry. Here's the correct url
https://www.codeaurora.org/cgit/quic/la/platform/system/core/tree/include/system/audio.h?h=jb_3.1#n357

Comment 3

[Michael Vines [:m1] [:evilmachines]]

https://hg.mozilla.org/projects/birch/rev/4289e7eb1826

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4289e7eb1826