893144 - [newsletter] /existing page styling is off

Status: RESOLVED FIXED

(www.mozilla.org :: Newsletters, defect)

Description

[Jessilyn Davis]

Attachment: Screenshot

See attachement.

Looks like the styling sheet on /newsletter/existing is messed up - the descriptions are all bolded and the newsletter titles are small.

Comment 1

[Dan Poirier [:dpoirier]]

Opened PR https://github.com/mozilla/bedrock/pull/1072 and asked sgarrity to review.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/7ec8b7aba21cf0bbb154b790786684cf7c126d91
Bug 893144 - /newsletter/existing/ styling

The styling sheet on /newsletter/existing ws messed up - the
descriptions were all bolded and the newsletter titles were small.

Reverted styling of the TH part of the table to what it was in an
earlier version of newsletter.less. No way to tell what happened
to it due to rebasing on the original branch.

https://github.com/mozilla/bedrock/commit/ea5ae0256de9ee75d94c5b1923d53c6d95b71775
Merge pull request #1072 from dpoirier/bug-893144-newsletter-existing-styling

Bug 893144 - /newsletter/existing/ styling

Comment 3

[raymond [:retornam] (inactive)]

I'll check this when it goes out to prod

Comment 4

[Jessilyn Davis]

Thanks Raymond! If you can check that the page still works for unsubscribing, and re-subscribing, updating language, etc. - that'd be spectacular! :D

(Ie change subscriptions for a subscriber, and when you go back to their email preference center (/en-US/) it should show your changes)

Comment 5

[Jessilyn Davis]

This went live - just stumbled upon it and gave it a whirl.

It looks good to me :)