893257 - Accepted Event Email Threads Chaotic

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect, P2)

Description

[Richard A Milewski[:richard]]

The subject line for an accepted event notification from the AirMo event wizard is always the same:

[Air Mozilla] Suggested event accepted!

This makes it very hard to find the email for a particular event as email clients try to "thread" them by subject.

Can we add an incrementing number to the events to keep the threads organized?

Comment 1

[Peter Bengtsson [:peterbe]]

The best way would be to use part of the event title into the subject line. Like::

 [Air Mozilla] Suggested event accepted! ("Mozilla IPOing next wee...")

Comment 2

[Peter Bengtsson [:peterbe]]

Should be easy to fix

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/f20c62f888728124d359ceeb4e8d83fd0e0dae65
fixes bug 893257 - Accepted Event Email Threads Chaotic

Comment 4

[Richard A Milewski[:richard]]

Am I missing something?   New Event Suggestion emails now have the the event title in the subject, But the Suggested Event Accepted emails still seem to have only one subject line.  (...and that's the one people reply to when they ask questions after submission).

Comment 5

[Peter Bengtsson [:peterbe]]

This is what the email looks like when an event is submitted:
"Subject: [Air Mozilla] New suggested event: Test of submission comments"
https://air-dev.allizom.org/media/emails/20130731-152107-140467949115536.log

This is what it looks like when it's rejected:
"Subject: [Air Mozilla] Suggested event not accepted"
https://air-dev.allizom.org/media/emails/20130731-113246-140467948699216.log

This is what the email looks like when an event is accepted:
"Subject: [Air Mozilla] Suggested event accepted! ("Can't Think Of Categories")" 
https://air-dev.allizom.org/media/emails/20130805-090834-140356677497104.log

What I can see is the title of the event is only included when it's submitted or accepted. Not when it's rejected. 

Also, I noted that it's inconsistent about how it includes the event title. One with quotation marks and brackets and one with nothing. 

What should it be?

Comment 6

[Peter Bengtsson [:peterbe]]

Please see comment #5

Comment 7

[Richard A Milewski[:richard]]

I think we need the title in all three.  I prefer the first form (no parentheses, no additional quotes).

Comment 8

[Peter Bengtsson [:peterbe]]

I took the liberty to change the word "Suggested" to "Requested" too. 

Now all different subject lines are like the first one.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/9e61adaf920c9b88187c48b38d52c8002e923fbf
fixes bug 893257 - Accepted Event Email Threads Chaotic