Closed
Bug 893283
Opened 11 years ago
Closed 11 years ago
Developer's name is missing from app
Categories
(Marketplace Graveyard :: Consumer Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2013-07-18
People
(Reporter: stephend, Assigned: basta)
References
()
Details
(Keywords: regression, Whiteboard: [fromAutomation])
Attachments
(3 files)
STR: 1. Load https://marketplace-dev.allizom.org/app/twitter?src=featured 2. Look for the developer's name Actual Results: It's missing (Compare screenshots.) Sauce Labs video: https://saucelabs.com/jobs/33eec10e2e7f494ba5a6519982cb5faf
Reporter | ||
Updated•11 years ago
|
Keywords: regression
Comment 1•11 years ago
|
||
Caused from Chuck's recent commit. Version is now its own resource. "current_version" went from being in the js object to a string that then needs to be pulled from versions (which is of the form {"1.0": "/path/to/resource"} to get the developer name and release notes.
Reporter | ||
Comment 2•11 years ago
|
||
https://github.com/mozilla/zamboni/commit/63c490b3dd309c0f2ad296cde4caa41fc6fd1541
Updated•11 years ago
|
Assignee: nobody → charmston
Target Milestone: --- → 2013-07-18
Updated•11 years ago
|
Assignee: charmston → cvan
Assignee | ||
Comment 4•11 years ago
|
||
https://github.com/mozilla/fireplace/commit/f3ac13e4ca6bd80c3bb8fe8978631b5dc53fa43d
Assignee: cvan → mattbasta
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
yoink
Reporter | ||
Comment 6•11 years ago
|
||
Reporter | ||
Comment 7•11 years ago
|
||
Verified FIXED on https://marketplace-dev.allizom.org/app/twitter?src=featured.
Status: RESOLVED → VERIFIED
Comment 8•11 years ago
|
||
The developer name that was rendered was incorrect. "Twitter, Inc." was the name of the user account who owned the Twitter app. Per bug 785125, we now pull the developer name from the app manifest. From Twitter's manifest https://mobile.twitter.com/cache/twitter.webapp: ... "developer": { "name": "Twitter", "url": "http://twitter.com" }, ... So we should be showing "Twitter" not "Twitter, Inc." as the developer name. Fixed: https://github.com/mozilla/zamboni/commit/21b105b https://github.com/mozilla/zamboni/commit/ef2975e https://github.com/mozilla/fireplace/commit/a1c66ee
Reporter | ||
Comment 9•11 years ago
|
||
Nice catch, thx again, cvan. <3
Comment 10•11 years ago
|
||
We are seeing this prod now. Our automated test caught this. Screenshot: http://imgur.com/kFEjamd
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 11•11 years ago
|
||
We're in the middle of a push and we're reindexing our search/detail pages (so you may see blank spots for a while); wait until it's done. Please reopen if needed. Thanks!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 12•11 years ago
|
||
Verified FIXED on https://marketplace.firefox.com/app/twitter?src=featured.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 13•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•