893329 - sign up button is not working of student ambassadors page

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Swarnava Sengupta (:Swarnava)]

go to

http://www.mozilla.org/en-US/contribute/universityambassadors/

fill the form and click on the sign me up button

its not working

Comment 1

[Jennifer Bertsch [:jbertsch]]

Thanks for reporting.

Team - this isn't working for me either.

Comment 2

[Chris More [:cmore]]

Confirmed that it is not working for me.

Comment 3

[Chris More [:cmore]]

Alex: It looks like you were the last person to work on this form and it is broken now. Not sure if a recent push broke something that this form is using.

Comment 4

[Alex Gibson [:agibson]]

PR here: https://github.com/mozilla/bedrock/pull/1068

Looks like this bug is a result of commit: https://github.com/mozilla/bedrock/commit/b6eed50f1f0757757721cd953b2a136194d111b2#media/js/base/footer-email-form.js

Simplest fix was to change the id of the ambassadors page form, since (I'm assuming) it was originally taken from the contribute page template, and hence had the same id.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a58f31a1b3dfb96b20abfbe2fa823063fdaec349
sign up button is not working of student ambassadors page bug 893329

Comment 6

[Jessilyn Davis]

Please let us know when/where this is ready to be tested.

Comment 7

[Katherine Naszradi [:knaszradi]]

Hi all:
Any thoughts on when this will be fixed? I've received a couple of pings about it already from potential members and I want to be sure to update them with the approximate date when they will be able to sign-up. Also, anything else you need from me here? Thanks!

Comment 8

[Paul [:pmac] McLanahan]

Hopefully going out within the hour. Already fixed on stage:

https://www.allizom.org/en-US/contribute/universityambassadors/

Comment 9

[Jessilyn Davis]

Attachment: error

Got a weird error on stage: "Input error: k: Format of site key was invalid"

Comment 10

[Paul [:pmac] McLanahan]

(In reply to Jessilyn Davis from comment #9)
That's the captcha, it's broken on stage.

Comment 11

[Jessilyn Davis]

Ah - cool - let us know when it goes live so we can test fully there.

THanks!

Comment 12

[raymond [:retornam] (inactive)]

This is on stage but we can only test when it goes to production due to the fact that reCAPTCHA is broken on stage.

Comment 13

[Paul [:pmac] McLanahan]

This is on prod now. WFM.

Also we could test the bug on stage, because the bug was the the submit button wasn't doing anything. I confirmed that after the change the submit button attempted to submit the form b/c I could see the form field validation kick in. We didn't need to fully test submission of this form in order to test the fix as the fix was purely client side.

I'm working on getting stage captchas fixed in bug 788690.

Comment 14

[Jessilyn Davis]

Raymond, can you test prod today?

Scenarios to test:

1) Sign up just for Student Ambassadors (don't check any other subscriptions) - make sure you get the welcome email in the right format, and when you go to your /existing (email pref center) you have just that flag chosen


2) Sign up for Student Ambassadors + other newsletters - make sure you get the welcome emails in the right format, and when you go to your /existing (email pref center) you have the right flags chosen


3) Make sure you show up in the STUDENT_AMBASSADORS data extension. You can send me your email addresses to check, or you/Rebecca can check by using the "Individual Email Lookup Student Ambassadors" query in ET.

Comment 15

[raymond [:retornam] (inactive)]

fixed on prod https://www.mozilla.org/en-US/contribute/universityambassadors/thanks/#ambassadors-form

Comment 16

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/3b984011f7d18ceeb86d1a5a55ecee702c79c64c
Adjust Russian tabzilla promo font size bug 893329

https://github.com/mozilla/bedrock/commit/bac61d7d8d791773ec9248f94ea9ef8485e41702
Merge pull request #1081 from alexgibson/adjust-russian-tabzilla-promo-text-size-bug-869004

Adjust Russian tabzilla promo font size bug 893329

Comment 17

[Alex Gibson [:agibson]]

Whoops I must have added the wrong bug number to that pull request in comment 16, sorry.

Comment 18

[Katherine Naszradi [:knaszradi]]

Just tested and form works for me! Can I let everyone know it's been fixed? Thanks! Kate

Comment 19

[Jessilyn Davis]

Yep! It's been verified that it's fixed. Alert away :)

Comment 20

[Katherine Naszradi [:knaszradi]]

Awesome - thanks all for your help here!

Comment 21

[Swarnava Sengupta (:Swarnava)]

Yes its working fine now

Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20100101 Firefox/22.0