893501 - Crash getting navigator.mozNotification from a stale navigator object

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

With:
  user_pref("notification.feature.enabled", true);

The testcase causes a crash [@ mozilla::dom::Navigator::GetMozNotification]

bp-1812654a-cd26-41df-b760-d805d2130714

Comment 1

[Jesse Ruderman]

Attachment: debug stack

Comment 2

[Scoobidiver (away)]

On Windows: bp-093320fc-3bf2-4296-a2a8-d10db2130714.

Comment 3

[Boris Zbarsky [:bzbarsky]]

William, is this enabled by default anywhere?

Comment 4

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 776371 [details] [diff] [review]
patch

r=me

Comment 6

[William Chen [:wchen]]

(In reply to Boris Zbarsky (:bz) from comment #3)
> William, is this enabled by default anywhere?

fennec

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c89df01905f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for Android mochitest-7 orange.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3169dd4bfb6

https://tbpl.mozilla.org/php/getParsedLog.php?id=25338785&tree=Mozilla-Inbound

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Looks like robocop-2 as well.
https://tbpl.mozilla.org/php/getParsedLog.php?id=25340542&tree=Mozilla-Inbound

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> Looks like robocop-2 as well.
> https://tbpl.mozilla.org/php/getParsedLog.php?id=25340542&tree=Mozilla-
> Inbound

This wasn't yours, just the mochitest-7.

Comment 11

[Andrea Marchesini [:baku]]

Attachment: crash2.patch

This is the patch without the test. The test will be submitted in a follow up.

Comment 12

[Andrea Marchesini [:baku]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/e37652a7c199

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e37652a7c199