893705 - Duplicate requests sometimes appearing in the network monitor

Status: RESOLVED WORKSFORME

(DevTools :: Netmonitor, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Attachment: test.html

STR:

1. Create a simple test.html document (use the attached file for example).
2. Start a server in that directory, for example using python
> python -m SimpleHTTPServer 1234
3. Open the simulator dashboard
4. "Add URL" for http://localhost:1234/test.html as an in the simulator
5. Click "Connect" for the newly installed app
6. Go to the Network Monitor
7. Refresh the app in the simulator (either via the Refresh button in the dashboard, or cmd/ctrl+R on the app itself)

The first GET request for test.html sometimes appears 2 or even 3 times in the requests menu. All the data for this request is the same, except for the content which is empty for all but the last one.

Sometimes this also happens in the webconsole, but I cannot reproduce it consistently. However, the symptoms seem to be the same: duplicate requests.

Mihai, is the webconsole guarding against such things? Can a networkEvent packet be sent multiple times for the same request?

This doesn't look like a simulator bug from my brief crude investigations (print something on load).

Comment 1

[Mihai Sucan [:msucan]]

Maybe the request channel object is changing during the request lifetime? See NRL__findOpenResponse() and NM_observeActivity() -- how they identify the same request. I haven't seen this issue with b2g desktop builds.

Can you please investigate with additional debugging/logging inside the two functions?

Comment 2

[Victor Porof [:vporof][:vp]]

Sure, that's the plan!

Comment 3

[Vangelis Katsikaros]

Attachment: work_for_me.png

I have the impression this is no longer relevant. I followed the STR but the problem doesn't show up with

>Version 	55.0a1
>Build ID 	20170413080758
>User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
and
>Version 	52.0.2
>Build ID 	20170329150849
>User Agent 	Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yeah, I think it's safe to close this one.

Thanks for testing!

Honza