893824 - 3D CSS Periodic demo crashes in CreateCGPattern

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

This bug was filed from the Socorro interface and is 
report bp-bafe6d4f-41e2-4738-8453-e94c42130715 .
 ============================================================= 

STR:
1) Open http://www.mrdoob.com/lab/javascript/threejs/css3d/periodictable/
2) Wait 5 seconds

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Don't create zero sized surfaces

The problem here was that we're trying to create a surface that is 0 sized.

CGImage creation fails (and dumps errors to stdout), and we fail DrawTarget::CreateSourceSurfaceForData.

We then fallback to Factory::CreateWrappingDataSurface which creates a SourceSurfaceRawData instead.

Then when we try draw with this surface we see that its type is TYPE_DATA, and static_cast it to DataSourceSurfaceCG.

We should probably fix that potential for an invalid cast too.

Comment 2

[Mike Hommey [:glandium]]

I don't which of bug 893824, bug 900133 or bug 898129 caused it, but inbound has been closed for long enough.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1009e4b1e1

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1b429edac78

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1b429edac78

Comment 5

[Paul Silaghi, QA [:pauly]]

Reproduced nightly 2013-07-15, Mac OS X 10.7.5.
Verified fixed FF 25.0a2 (2013-09-12), 26.0a1 (2013-09-12).