Closed
Bug 893834
Opened 11 years ago
Closed 11 years ago
Upgrade user item template to Foundation 4
Categories
(Mozilla Reps Graveyard :: reps.mozilla.org, task)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: hoosteeno, Assigned: agibson)
References
Details
(Whiteboard: [kb=1045360] )
We're going to begin upgrading Reps to Foundation 4. We'd like to do it inside our normal dev workflow, rather than creating a separate feature branch with a huge amount of code and a separate demo server to test it and a huge QA effort and a huge launch in the future. First step: Create a new base template and new styles and apply them to a single page, and try to make it a clean PR. Suggestion: Do it on the user page (https://reps.mozilla.org/u/rskikuli/).
Reporter | ||
Updated•11 years ago
|
Whiteboard: [kb=1045360]
Reporter | ||
Comment 1•11 years ago
|
||
Just to clarify: the suggestion above is to modify the template at /u/, not just that particular user's page. If using django-waffle would help, it is available.
Assignee | ||
Comment 2•11 years ago
|
||
PR submitted here: https://github.com/mozilla/remo/pull/437 This provides a new base template using foundation 4, along with an updated profiles view. The profiles view is the only page that utilizes the foundation 4 framework. All other pages are unaffected by this change.
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/remo https://github.com/mozilla/remo/commit/93eee48bc5dca9f0e7aded13cd647c03295cef4a [fix bug 893834] Upgrade user item template to Foundation 4 https://github.com/mozilla/remo/commit/a2e82a56b3f9a7a0afd22a7dc486a0526341bc75 Merge pull request #437 from alexgibson/upgrade-user-item-template-foundation-4-bug-893834 [fix bug 893834] Upgrade user item template to Foundation 4
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Version: unspecified → 410
Comment 4•11 years ago
|
||
Verified on stage with Rep, Council, Mentor, Admin, Mozillian bit and as anonymous user.
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•11 years ago
|
Version: 410 → 411
Updated•4 years ago
|
Product: Mozilla Reps → Mozilla Reps Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•