893849 - Search box should fill entire width of panel if in panel

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

STR:

1. Enter customize mode
2. Move search box to panel
3. Exit customize mode
4. Open menupanel

(search box now has whatever width it had before being moved to the panel)

5. Restart your browser
6. Open menupanel

(search box now has the default width, or something?)

ER:

We should make sure the search box always takes up the full width of the panel, and a default width once you move it back to the navbar (unless you move it straight back in the same process to when it was next to the navbar, in which case we can probably resize it to match its previous size?)

Comment 2

[:Gijs (he/him)]

This is about the menupanel, not the overflow panel.

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #2)
> This is about the menupanel, not the overflow panel.

(also, to fix this properly it needs to be treated like the other wide panel widgets, which I'd like to fix by generalizing their onWidget* handlers into a single one that fixes the entire panel's ordering, which I'm working on in bug 885579)

Comment 4

[Florian Bender]

You may want to block Bug 918551 on this one.

Comment 5

[:Gijs (he/him)]

Stealing per discussion on IRC

Comment 6

[:Gijs (he/him)]

Attachment: search box should fill entire width of panel, part 1: change class name, apply to search box,

This is pretty straightforward, but it isn't enough because if you've used the splitter to change the widths of the urlbar and searchbar, that width persists into the panel or palette. However, it does that now, too, and this patch makes things strictly better (and makes it possible for the Add-on SDK to use this class, too) so I want to get this out of the way while I figure out how to best deal with the width issues...

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 815365 [details] [diff] [review]
search box should fill entire width of panel, part 1: change class name, apply to search box,

Review of attachment 815365 [details] [diff] [review]:
-----------------------------------------------------------------

This makes things nicely readable. Thanks!

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/a5c17d687ccf

Comment 9

[:Gijs (he/him)]

Comment on attachment 815365 [details] [diff] [review]
search box should fill entire width of panel, part 1: change class name, apply to search box,

>diff --git a/browser/themes/shared/customizableui/panelUIOverlay.inc.css b/browser/themes/shared/customizableui/panelUIOverlay.inc.css
<snip>
>+#search-container@inAnyPanel@,
> #edit-controls@inAnyPanel@,
> #edit-controls@inAnyPanel@ > toolbarbutton,
> #zoom-controls@inAnyPanel@,
> #zoom-controls@inAnyPanel@ > toolbarbutton {
>   -moz-box-flex: 1;
> }

I didn't land this bit because it's a no-op. New patch to fix the width coming up in a sec, which also removes the rules for the edit/zoom-controls.

Comment 10

[:Gijs (he/him)]

Attachment: search box should fill entire width of panel if in panel, part 2: fix width for search panel in panels,

Simpler than I thought in the end. This works.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 815494 [details] [diff] [review]
search box should fill entire width of panel if in panel, part 2: fix width for search panel in panels,

Review of attachment 815494 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 12

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/e6cd734560ac

Comment 13

[Florian Bender]

Attachment: australis-menu-panel-wide-item.png

This is how it currently looks like for me. So the box is now a bit too wide (or needs even margins). Shall I file a new bug, or do you intend to cover this in this bug?

Comment 14

[:Gijs (he/him)]

(In reply to Florian Bender from comment #13)
> Created attachment 822827 [details]
> australis-menu-panel-wide-item.png
> 
> This is how it currently looks like for me. So the box is now a bit too wide
> (or needs even margins). Shall I file a new bug, or do you intend to cover
> this in this bug?

Can you make a screenshot including context? I'm guessing you had the right edge of the window at the edge of the screen, which means this looks like bug 874792 to me - everything is lacking margins, which is because the "keep this panel onscreen" bits have made it narrower on the right side. This is also why the quit button looks cropped. :-(

Comment 15

[Florian Bender]

Yeah this is due to the window reaching all the way to the edge. If I move the window to the left, the margins look good. 

Definitely needs to be fixed before Release, I guess most people are running Fx fullscreen (because mostly they have about 13" displays) … well, Bug 874792 then. Thanks!

Comment 16

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/a5c17d687ccf
https://hg.mozilla.org/mozilla-central/rev/e6cd734560ac