893899 - JS TypeError on TopCrashers

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Lonnen :lonnen]

There are 9 typeerrors when I load https://crash-stats.mozilla.com/topcrasher/products/Firefox/versions/25.0a1 in FF 25.0a1 (nightly). I've mapped them all back to the following line of unminified code - https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/static/crashstats/js/socorro/topcrash.js#L124

The callback in that line is being called with no arguments sometimes. We should make it more robust.

Comment 1

[Robert Helmer [:rhelmer]]

I suspect this was caused by bug 876022

Comment 2

[Lonnen :lonnen]

peterbe: "I'd rather we change how we're proxying the mware in the django view code."

Comment 4

[Peter Bengtsson [:peterbe]]

New PR https://github.com/mozilla/socorro-crashstats/pull/428
:rhelmer r?

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c0144ae1d4019d03c1a92a8297ee59dcd285a6ed
fixes bug 893899 - JS TypeError on TopCrashers

https://github.com/mozilla/socorro/commit/b1f75e5bbff9895f64b1ab9f2ea49a2e96a5e759
Merge pull request #1351 from lonnen/pr-428

fixes bug 893899

Comment 7

[Scoobidiver (away)]

Socorro 54 or 55?

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6d936d1cf671aa76453ab88d4129430ebf17c8c3
fixed bug 893899

https://github.com/mozilla/socorro/commit/23c2b85eece7e7b2336820d1196d5ec8bc6008d2
Merge pull request #1353 from lonnen/bug893899

fixed bug 893899

Comment 9

[Peter Bengtsson [:peterbe]]

Because the merge was a bit chaotic as we're moving from socorro-crashstats to socorro, I'll have to refer to the guy who did it all.

Comment 10

[Scoobidiver (away)]

(In reply to Scoobidiver from comment #7)
> Socorro 54 or 55?
It seems it landed on prod, currently Socorro 53.

Comment 11

[Lonnen :lonnen]

This landed everywhere.

Comment 12

[Matt Brandt [:mbrandt]]

QA verified on prod - looks great, zero js errors