Closed
Bug 894715
Opened 11 years ago
Closed 11 years ago
Defect - URLs selected by touch are copied from the urlbar with trimming
Categories
(Firefox for Metro Graveyard :: App Bar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: jwilde, Assigned: jwilde)
References
Details
(Whiteboard: [preview])
Attachments
(2 files)
1.65 KB,
patch
|
sfoster
:
review+
|
Details | Diff | Splinter Review |
3.22 KB,
patch
|
ally
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: - Go to a page - Swipe up to reveal the navbar - Tap on the text to select it - Long press to reveal the context menu - Tap "copy" ... - Paste somewhere else Expected result: Pasted text should be the entire, untrimmed URL. Actual result: Pasted text is the trimmed URL.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jwilde
Status: NEW → ASSIGNED
Updated•11 years ago
|
Whiteboard: [preview]
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #784734 -
Flags: review?(sfoster)
Comment 2•11 years ago
|
||
Comment on attachment 784734 [details] [diff] [review] failing testcase Review of attachment 784734 [details] [diff] [review]: ----------------------------------------------------------------- Correctly (currently) fails. Looks good.
Attachment #784734 -
Flags: review?(sfoster) → review+
Assignee | ||
Comment 3•11 years ago
|
||
As far as I can tell, this doesn't break anything.
Attachment #788035 -
Flags: review?(jmathies)
Comment 4•11 years ago
|
||
(In reply to Jonathan Wilde [:jwilde] from comment #3) > Created attachment 788035 [details] [diff] [review] > patch v0 > > As far as I can tell, this doesn't break anything. What the heck are you still doing up at this hour? :)
Comment 5•11 years ago
|
||
Comment on attachment 788035 [details] [diff] [review] patch v0 Review of attachment 788035 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for reducing the number of code paths while fixing the issue. Also for abiding by the metro style guide. I know you've run the tests locally, but please doublecheck on try before landing. Please file a followup for more tests.
Attachment #788035 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Followup is bug 903677, try run is at: https://tbpl.mozilla.org/?tree=Try&rev=bf5546db8b66
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/141402d84ef5 https://hg.mozilla.org/integration/fx-team/rev/6ad5e7c6ecf2
Whiteboard: [preview] → [preview][fixed-in-fx-team]
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/141402d84ef5 https://hg.mozilla.org/mozilla-central/rev/6ad5e7c6ecf2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [preview][fixed-in-fx-team] → [preview]
Target Milestone: --- → Firefox 26
You need to log in
before you can comment on or make changes to this bug.
Description
•