894908 - Minor profile cleanup tasks in preparation for launch

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

A handful of things we'd like to fix before launching:

* on edit, make "when did you get involved" go from 1998-current_year
* on edit, add borders around input boxes on profile edit
* on edit, get rid of day on "when did you get involved"
* on edit, _try_ to keep font from being clipped top/bottom in input boxes
* on edit, remove "preferred language" element
* on edit, make "language" block look like skills/groups blocks
* on edit, change "other languages you speak" to "languages you speak"
* on edit, somehow make profile delete button a little less easy/fun to click
* on edit, the "visible to" label on groups/skills is a different font style from the others
* on view, get rid of the space before the comma when there are multiple groups

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

The PR for this is here:

https://github.com/mozilla/mozillians/pull/549

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/40d1e58b7fb9851fc089328b7e56ce2b13188a71
[Fix Bug 894908] Minor fixes to profile and edit profile view.

Comment 3

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening:

Each requirement in comment 0 looks great (has been met) except for one.

* on view, get rid of the space before the comma when there are multiple groups
- see attached screenshot

Note these look great:
* on edit, make "when did you get involved" go from 1998-current_year
* on edit, add borders around input boxes on profile edit
* on edit, get rid of day on "when did you get involved"
* on edit, _try_ to keep font from being clipped top/bottom in input boxes
* on edit, remove "preferred language" element
* on edit, make "language" block look like skills/groups blocks
* on edit, change "other languages you speak" to "languages you speak"
* on edit, somehow make profile delete button a little less easy/fun to click
* on edit, the "visible to" label on groups/skills is a different font style from the others

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/cd530880cbb0c1a87b21bd3b346c301bb882f2ab
[fix bug 894908] Get rid of the space before the comma when there are multiple groups.

https://github.com/mozilla/mozillians/commit/6904dbc739b97e9ada551fedd45ae935515c3488
Merge pull request #564 from glogiotatidis/mozilla/master

[fix bug 894908] Get rid of the space before the comma when there are multiple groups.

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

QA verified on stage - woot ya. Thanks Giorgos, spaces before commas removed.