895007 - Handle zero size native drawing more gracefully.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Handle zero size native drawing more gracefully.

This is causing crashes with CoreGraphics Azure.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 777236 [details] [diff] [review]
Handle zero size native drawing more gracefully.

Review of attachment 777236 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxQuartzNativeDrawing.cpp
@@ +43,5 @@
>          IntSize backingSize(NSToIntFloor(mNativeRect.width * mBackingScale),
>                              NSToIntFloor(mNativeRect.height * mBackingScale));
> +
> +       if (backingSize.IsEmpty())
> +          return nullptr;

Couldn't we assert that mBackingScale is never 0, and then move this check up to the root scope of this function?

Seems better than having the overhead of borrowing our CGContext, or creating an temporary cairo surface if nothing is going to be drawn.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/605f61628a4b