895299 - [b2g-bluetooth] Enable A2DP and AVRCP in audio config for BlueZ

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

A2DP 1.2 and AVRCP 1.0 has been landed on m-c (bug 872907, bug 834554). Review process of AVRCP 1.3 is ongoing (bug 834554).

We should enable A2DP and AVRCP in master branch. Otherwise, A2DP and AVRCP connection cann't be established successfully.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

(In reply to Gina Yeh [:gyeh] [:ginayeh] from comment #0)
> A2DP 1.2 and AVRCP 1.0 has been landed on m-c (bug 872907, bug 834554).
> Review process of AVRCP 1.3 is ongoing (bug 834554).

typo:
  Please see bug 887623 for more details of AVRCP 1.3.

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: unagi: Link to https://github.com/mozilla-b2g/android-device-unagi/pull/14/files

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

I'll send PRs for each device separately.

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 777646 [details]
unagi: Link to https://github.com/mozilla-b2g/android-device-unagi/pull/14/files

Marco, please help to check it. Thanks.

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: otoro: Llink to https://github.com/mozilla-b2g/android-device-otoro/pull/24

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: leo: Link to https://github.com/mozilla-b2g/device-leo/pull/6/files

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: otoro: Llink to https://github.com/mozilla-b2g/android-device-otoro/pull/25/files

updated

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: leo: Link to https://github.com/mozilla-b2g/device-leo/pull/7/files

updated.

Comment 9

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: inari: Link to https://github.com/mozilla-b2g/device-inari/pull/7/files

Comment 10

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: hamachi: Link to https://github.com/mozilla-b2g/android-device-hamachi/pull/7/files

Comment 11

[Gina Yeh [:gyeh] [:ginayeh]]

Hello mwu,

I'm not sure if we need to update audio.conf for keon and peak on master branch. Do you have any idea? Thanks.

Comment 12

[Gina Yeh [:gyeh] [:ginayeh]]

I'm going to close this bug and file new bugs for tracking keon and peak.

Comment 13

[Gina Yeh [:gyeh] [:ginayeh]]

These PR haven't been merged yet. Let's re-open this bug.

Comment 14

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [leo] Link to https://github.com/mozilla-b2g/device-leo/pull/8

Marco, please help to merge this PR.

Comment 15

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [unagi] Link to https://github.com/mozilla-b2g/android-device-unagi/pull/15

Marco, please help to merge this PR.

Comment 16

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [inari] Link to https://github.com/mozilla-b2g/device-inari/pull/8

Marco, please help to merge this PR.

Comment 17

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [otoro] Link to https://github.com/mozilla-b2g/android-device-otoro/pull/26

Marco, please help to merge this PR.

Comment 18

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [hamachi] Link to https://github.com/mozilla-b2g/android-device-hamachi/pull/8

Marco, please help to merge this PR.

Comment 19

[Ed Morley [:emorley]]

I had to revert this:
https://github.com/mozilla-b2g/device-inari/commit/aa311599041d0a3fcce1d841c9b96c10eb18ac94

Due to:
https://tbpl.mozilla.org/php/getParsedLog.php?id=25957819&tree=Birch#error0

Comment 20

[Ed Morley [:emorley]]

(the inari part)

Comment 21

[Ed Morley [:emorley]]

There was also the same typo in the android-device-otoro and android-device-hamachi commits, so reverted those too:
https://github.com/mozilla-b2g/android-device-otoro/commit/29aa73f095d9ff413004b708ea8a8112721ead72

https://github.com/mozilla-b2g/android-device-hamachi/commit/80d4571ba16f15b7675be0be64b2a7e046547d8a

Comment 22

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi,

Back slashes are missing in the pull requests for inari, otoro and hamachi at least.

Comment 23

[Gina Yeh [:gyeh] [:ginayeh]]

Sorry for the build break. Let me re-send the PRs again.

Comment 24

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [hamachi] Link to https://github.com/mozilla-b2g/android-device-hamachi/pull/9

Comment 25

[Marco Chen [:mchen]]

Hi Ed & Thomas,

Thanks for your help on this case and I should checked this.

Comment 26

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [otoro] Link to https://github.com/mozilla-b2g/android-device-otoro/pull/27

Comment 27

[Ed Morley [:emorley]]

(In reply to Marco Chen [:mchen] from comment #25)
> Hi Ed & Thomas,
> 
> Thanks for your help on this case and I should checked this.

Np :-)

Comment 28

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [inari] Link to https://github.com/mozilla-b2g/device-inari/pull/10

Comment 29

[Gina Yeh [:gyeh] [:ginayeh]]

All PRs has been merged. Let's close this bug.