895480 - Bluetooth app tries to handle Share URL activity and fails

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Ben Francis [:benfrancis]]

STR:

* Open browser app
* Navigate to a web site
* Click the share button in the bottom toolbar

Expected:
* Bluetooth app handles the activity correctly or not at all

Actual:
Bluetooth app tries to handle the web activity and shows an error saying that it failed

Comment 1

[[e-mail], [e-mail]]

Sharing url to other bluetooth devices is not in the previous scope. I would like to handle the issue with not at all. It will need to add some filter for excluding type 'url' in the manifest. But the share button will be useless in the bottom toolbar. It should be grey out or do some other interaction. I don't know the user story for the share bottom in Browser app.

Then, we can create another issue for the feature. We should share the 'url' like a text file to other devices. It will need a discussion.
Bug 897375 - Bluetooth app supports to handle Share URL activity to other devices

Comment 2

[Jason Smith [:jsmith]]

Adding needinfo on product per productwanted request.

Comment 3

[Soledad Penades [:sole] [:spenades]]

Ah, I think I'm having this issue.

I'm trying to share a image generated in my app, and even if the blob is "perfect" (I can build a URL and navigate to that URL, and it shows the image properly), I am getting a "Bluetooth file transfer failed. Check that the Bluetooth settings are correct" message.

From what I read in this bug description, since I am trying this on a brand new phone and I haven't installed any apps other than mine, I figure that there are no other applications with support for the sharing activity other than the Bluetooth app, and it's failing at handling the activity-maybe I haven't configured Bluetooth?

Is there any way to see what apps are registered as supporting the share activity?

I'd suggest either show the list of available apps or at least have the Bluetooth app not fail with such a strange message.

Comment 4

[Peter Dolanjski [:pdol]]

(In reply to Ian Liu [:ianliu] from comment #1)
> Sharing url to other bluetooth devices is not in the previous scope. I would
> like to handle the issue with not at all. 

This sounds like the right approach until this feature is fully implemented.

Comment 5

[Ben Francis [:benfrancis]]

Blocks a koi+ bug

Comment 6

[Dale Harvey (:daleharvey)]

> Sharing url to other bluetooth devices is not in the previous scope. I would
> like to handle the issue with not at all. 

While the feature isnt implemented the bluetooth applications needs to not be registered as being able to receive the share activity invoked with a url, thats what this bug is

Comment 7

[David Flanagan [:djf]]

(In reply to Dale Harvey (:daleharvey) from comment #6)
> > Sharing url to other bluetooth devices is not in the previous scope. I would
> > like to handle the issue with not at all. 
> 
> While the feature isnt implemented the bluetooth applications needs to not
> be registered as being able to receive the share activity invoked with a
> url, thats what this bug is

If so, that should just be a one or two line change to the manifest file to add a filter on the type field.

Ideally, "Bluetooth" should only show up in the menu for types that the bluetooth app actually knows how to share.

Comment 8

[David Flanagan [:djf]]

Looks like the bluetooth app ignores the type of the activity request and will handle any share request that has an array named blobs.

So I think you ought to be able to add a filter to the manifest that makes 'blobs' a required property. That way, bluetooth will only be listed when the activity request includes that property.

Comment 9

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request 12486.html

According to Comment 8, add correct filter "type" and "blobs" required for supported "share activity" of Bluetooth app.

David,

Could you please help to review the patch? Thank you so much.

Comment 10

[David Flanagan [:djf]]

Comment on attachment 808412 [details]
Pointer to Github pull request 12486.html

The code looks good to me, but I did not test it. Assuming you have tested it, it looks good to land.

Comment 11

[[e-mail], [e-mail]]

I have done manual test for sharing picture/music/video/contacts via Bluetooth. It's working fine for me. Thanks for David's reviewing effort.

Gaia/master:  db54b9d0de74307ad50764cf713662a8de50946a

Comment 13

[James Lal [:lightsofapollo]]

reverted here: https://github.com/mozilla-b2g/gaia/commit/9563c38e0cd3fbaaec2a40cd525baf7df5098f2f

This fails a gaia integration test

Comment 14

[[e-mail], [e-mail]]

Comment on attachment 808412 [details]
Pointer to Github pull request 12486.html

><!DOCTYPE html>
><html>
>  <head>
>    <meta charset="utf-8" />
>
>    <title></title>
>
>    <meta http-equiv="refresh" content="0;url=https://github.com/mozilla-b2g/gaia/pull/12486" />
>
>  </head>
>
>  <body>
>
>    Redirecting to => https://github.com/mozilla-b2g/gaia/pull/12486
>
>  </body>
></html>

Comment 15

[[e-mail], [e-mail]]

Comment on attachment 808412 [details]
Pointer to Github pull request 12486.html

Obsolete the attachment. I will create another one.

Comment 16

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request 12486.html

Hi Gareth,

Could you please help to review the integration test section? I remove one step(click E-Mail button from share menu), since there is only one share url activity supported. Thanks.

Comment 17

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 810929 [details]
Pointer to Github pull request 12486.html

LGTM! Thanks Ian!

Comment 18

[[e-mail], [e-mail]]

Gareth,

Thanks for your reviewing effort. And sorry for breaking integration test before.

Since the pr is merged, we can close the issue now. 
Gaia/master: ab8fbea15b80297105f63efd7c55c24460ac555c

Comment 19

[Natalya Kot [:nkot]]

Verified fixed on Buri m-c

- works as supposed to per comment 16 - //Since share url via email is supported only, email share url activity handles the request directly.

Gaia   959ac2f692d85072ffdc3d16a041b5bf4735ae59
SourceStamp aa986b6ce882
BuildID 20131010040202
Version 27.0a1

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted ab8fbea15b80297105f63efd7c55c24460ac555c to:
v1.2: dd4b941d389baf27413f52910a4c3f66aa233bbc

Comment 21

[Chris Kreinbring [:CKreinbring]]

Fix verified on Buri 1.2 mozilla RIL.  Tapping the share button while in a browser site will open an email with a link to that site.

Build ID: 20131017004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/7ca5d1e81d37
Gaia: dbcc171eae6b4d9d168a48291d5ea54c7580561a
Platform Version: 26.0a2