Closed Bug 895606 Opened 11 years ago Closed 10 years ago

Implement webmaker.org requirejs optimization

Categories

(Webmaker Graveyard :: webmaker.org, defect)

Product:
Webmaker Graveyard
Component:
webmaker.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: kate, Unassigned)

References

Details

(Whiteboard: frontend, postfest, icebox) 

Right now we are not running our js through requirejs optimization for production -- we should be.
Whiteboard: s=2013w30 p=1, frontend
Whiteboard: s=2013w30 p=1, frontend → s=20130722 p=1, frontend
Bumping this, should be done by MozFest IMO
Whiteboard: s=20130722 p=1, frontend → mozfest
Assignee: kate → nobody
Dale, do you feel confident with this and Web Lit?
Assignee: nobody → dale
Yep!
Removing mozfest flag
Whiteboard: mozfest
Jon, can you help me come to a decision on our RequireJS optimization strategy?

You've wanted to use your middleware, but is this something we really need middleware for? I've had problems getting the middleware to work. I think including our RequireJS build step in grunt would make more sense; it's an action that we really only need to do once per deploy in production mode. JS won't be changing mid-deploy, so we shouldn't need to run each request through a middleware (unless I am mistaken in how Connect/ExpressJS middleware works).
Flags: needinfo?(jon)
If you can get the grunt task working, go for it, but it's just a blob of json either way to configure it.
Flags: needinfo?(jon)
Whiteboard: frontend, postfest
Assignee: dale → gavin
Assignee: gavin → nobody
Whiteboard: frontend, postfest → frontend, postfest, icebox
no longer relevant given current codebase
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Resolution: FIXED → INVALID
You need to log in before you can comment on or make changes to this bug.