895669 - Change - override about:addons to display a metro custom page

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[Allison Naaktgeboren :ally]

Since we are not allowing addons in v1, we should disable the ability to access about:addons, as the current about:addons looks very functional and gives no indication that metro addons are not supported.

Comment 1

[Allison Naaktgeboren :ally]

Attachment: debugging

Comment 2

[Allison Naaktgeboren :ally]

as discussed on irc with mfinkle & yuan, the plan is now to override extensions.xul to display a custom page with a cute image and short, localizable message indicated that addons are not currently supported.

Comment 3

[Allison Naaktgeboren :ally]

Attachment: wip, works, but is u-g-l-y

it seems like it can't find the css file.
also the new files have icky windows line endings.

Comment 4

[Allison Naaktgeboren :ally]

Attachment: metroaboutaddons

Comment 5

[Allison Naaktgeboren :ally]

Attachment: Screenshot

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 784542 [details] [diff] [review]
metroaboutaddons

Review of attachment 784542 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!
Just this thought for snapped-view (which I know we already determined was low priority)

::: browser/metro/theme/aboutAddons.css
@@ +2,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +html, body {
> +  height: 100%;

If you add: 
padding: 0; 
margin: 0; 
..here you'll get edge-edge color which I think you want.

@@ +28,5 @@
> +  text-align: left;
> +  word-wrap: normal;
> +}
> +
> +#fox {  

nit: trailing whitespace

@@ +36,5 @@
> +  background-position: bottom center;
> +  background-repeat: no-repeat, repeat-x;
> +  background-color: rgb(230, 230, 230); /*color hand sampled from image*/
> +
> +}

You add something simple like the following to get something quite usable for snapped-view: 

/* Snapped-view variation */
@media (max-width: 330px) {

  #floatingTextBox {
    top: 20%;
    left: 5%;
    width: 90%;
  }

}

Comment 7

[Allison Naaktgeboren :ally]

Attachment: r+ with nits & media query

my thinkpad is rendering large black bars for snapped view still, so I can't actually test the snapped part of that patch yet. Builds are running and it'll be a race to verify

Comment 8

[Allison Naaktgeboren :ally]

Attachment: r+ w/nits and tweaked media query

thanks Rodrigo!

Comment 9

[Allison Naaktgeboren :ally]

Attachment: r+ with nits, media query, tweaked padding checkin on fx-team

wish bugzilla had a good way to preview the text of the patch so you could doublecheck that the file contains the right version.

Comment 10

[Allison Naaktgeboren :ally]

Metro team is now checking in code on fx-team not inbound, and fx-team has been closed for most of today.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b5abcd08bf67

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b5abcd08bf67

Comment 13

[Manuela Muntean [Away]]

Attachment: screenshot.png

Please see the attached screenshot. This is how it looks for me the about:addons page, on a Win 8 64bit machine, using the latest Nightly, build ID: 20130819030205, tested for iteration #12.

Is this the expected?

Comment 14

[Asa Dotzler [:asa]]

Yes, this is the expected content.

Comment 15

[Manuela Muntean [Away]]

Thanks! :)

Marking this VERIFIED, based on comment 13 and comment 14.

Comment 16

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Change" for iteration #16 and found some issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-23-03-02-05-mozilla-central/

- Went through the suggestions throughout the thread and ensured everything described was implemented and working
- Went to "about:addons" and ensured that the correct image appeared
- Ensured that "Nightly Start Page" redirects the user to the awesome screen without any issues
- Viewed "about:addons" in full, filled and snap view and ensured that the image is displayed correctly
- Went through the above test cases in both Windows 8 and Windows 8.1

Issues:

Ran into a small issue when going through the change in Windows 8.1. When you view the page in the different views, the text will but cut off at times. In Windows 8, it auto corrects and appears correctly but in 8.1 it stays cut off. Created Bug 930367