Closed
Bug 896034
Opened 11 years ago
Closed 11 years ago
Send an email when a region is added
Categories
(Marketplace Graveyard :: Payments/Refunds, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-08-13
People
(Reporter: andy+bugzilla, Assigned: davidbgk)
References
Details
When a new paid region is added to the marketplace we need to let developers of paid apps know this. For example, when we add in Seahorse, developers might need to add that in. There are two scenarios: * either a user has selected the "automatically add me to new regions" checkbox (http://cl.ly/image/2O0p0N211y3X) and so they are going to be automatically added for that app * they haven't In the former case, they should get an email letting them know they have been automatically added. In the latter case, they should get an email telling them to go to the devhub and update it. Lets add these two scenarios to the existing admin email tool (see /admin/email-devs on your favorite zamboni instance). http://cl.ly/image/472d3l2P3l3o
Flags: affects-seahorse+
Reporter | ||
Comment 1•11 years ago
|
||
Assigned to David, but hoping Stuart since he's in your timezone you can help out with all the questions he's going to have, mostly getting the query right.
Assignee: nobody → david
Reporter | ||
Updated•11 years ago
|
Priority: -- → P3
Comment 2•11 years ago
|
||
Feel free to reuse this: https://github.com/mozilla/zamboni/blob/b43d7a235/mkt/developers/cron.py#L18 https://github.com/mozilla/zamboni/blob/b43d7a235/mkt/developers/tasks.py#L569
Reporter | ||
Updated•11 years ago
|
Target Milestone: --- → 2013-07-25
Assignee | ||
Comment 3•11 years ago
|
||
If I understand correctly, the first case is already handled by the code pointed by Christopher and I have to adapt it for the particular case of developers who haven't checked the "automatically add me to new regions" checkbox. Dealing with new email templates asking those developers if they're sure not to be visible in the newly added region. Am I right? (+ admin integration)
Comment 4•11 years ago
|
||
Bear in mind that currently for paid apps the worldwide checkbox is currently disabled. I've added that bug to this as a dependency.
Depends on: 883933
Reporter | ||
Comment 5•11 years ago
|
||
FYI the email we are planning on sending looks like this: https://etherpad.mozilla.org/payments-region-emails Presuming this form can take some values like {{ app name }}.
Assignee | ||
Comment 6•11 years ago
|
||
Don't we make the distinction anymore with one/two/many regions added? https://github.com/mozilla/zamboni/tree/master/mkt/developers/templates/developers/emails
Reporter | ||
Comment 7•11 years ago
|
||
No idea what those templates are for tbh. The adding in of the payments for a region is a different action from adding in the region though.
Assignee | ||
Comment 8•11 years ago
|
||
These templates are in use within the region_email task: https://github.com/mozilla/zamboni/blob/master/mkt/developers/tasks.py#L568 Isn't it what this bug is related to? To me we just have to distinguish between worldwide/local and thus update the templates accordingly as I partly did in: https://github.com/davidbgk/zamboni/commit/40d4202779943dc0c7157ea19e6a34c567e88172#L4R0
Reporter | ||
Updated•11 years ago
|
Target Milestone: 2013-07-25 → 2013-08-01
Assignee | ||
Updated•11 years ago
|
Target Milestone: 2013-08-01 → 2013-08-08
Reporter | ||
Comment 9•11 years ago
|
||
From etherpad: ./manage.py email_developers_about_new_paid_region <region_slug>
Reporter | ||
Comment 10•11 years ago
|
||
You've got the management command in, is there anything else to do on this?
Assignee | ||
Comment 11•11 years ago
|
||
Reviewing https://github.com/mozilla/zamboni/pull/958
Reporter | ||
Updated•11 years ago
|
Target Milestone: 2013-08-06 → 2013-08-13
Assignee | ||
Comment 12•11 years ago
|
||
https://github.com/mozilla/zamboni/commit/db6f7f375c25ee367390fbcf285f2c018aed2ffd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 13•11 years ago
|
||
Please add STR here or mark it with [qa-] if no QA is needed.
Flags: needinfo?(amckay)
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(amckay)
You need to log in
before you can comment on or make changes to this bug.
Description
•