Closed Bug 896461 Opened 11 years ago Closed 11 years ago

Defect - Firefox logo showing up in Top Sites tiles

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Firefox Start
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 25

People

(Reporter: jimm, Assigned: sfoster)

References

Details

(Whiteboard: feature=defect c=tbd u=tbd p=2)

Attachments

(3 files)

Screenshot (57).png
46.10 KB, image/png
Details
Fix lazy-loading of OS.File module
1.02 KB, patch
jimm
: review+
Details | Diff | Splinter Review
screenshot_Nightly_2013-07-29
250.63 KB, image/png
Details
Attached image Screenshot (57).png — 
From a build off tip this morning. Looks like a bug.
I'm seeing 0 background thumbnails as well as of this morning. (the firefox watermark is the default thumbnail used when we fail to get a screenshot thumbnail for whatever reason)

Not sure if this is fall-out from bug 892632 (shouldn't be, I tested that pretty thoroughly) or maybe bug 870100 or something nearby.
Summary: Firefox logo showing up in Top Sites tiles → Defect - Firefox logo showing up in Top Sites tiles
Whiteboard: feature=defect c=tbd u=tbd p=0
Assignee: nobody → sfoster
Blocks: metrov1it11
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=2
Priority: -- → P2
I tracked this down finally to a typo in browser-scripts where we import the osfile.jsm module that gives us OS.File.exists.
Attachment #780474 - Flags: review?(jmathies)
Attachment #780474 - Attachment is patch: true
Attachment #780474 - Attachment mime type: message/rfc822 → text/plain
Attachment #780474 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/7b72f5bd90d0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
with the latest Nightly: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130729 Firefox/25.0

This issue isn't totally solved. For example, for Facebook and Vimeo, the Firefox logo is still showing up in Top Sites tiles.

Please see the attached screenshot for details.
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: