Closed
Bug 896500
Opened 11 years ago
Closed 11 years ago
Merge headers in Popcorn maker
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kate, Assigned: mjschranz)
References
Details
(Whiteboard: wm-userbar, frontend)
Attachments
(1 file, 1 obsolete file)
- Move ssoux stuff to main header - Remove top header Mock: - http://dl.dropbox.com/u/29163874/Screenshots/jw.png Complete designs: - https://bugzilla.mozilla.org/show_bug.cgi?id=890675
|
Reporter | |
Comment 1•11 years ago
|
||
Also, let's use an svg version of the PopcornMaker logo while we are here
|
Assignee | |
Comment 2•11 years ago
|
||
My only thing is, I wouldn't know how to make/get our logo in SVG format. Can you help me with that Kate?
Assignee: nobody → schranz.m
Status: NEW → ASSIGNED
Flags: needinfo?(kate)
|
|
Assignee | |
Comment 3•11 years ago
|
||
PM work. Kate said she would do the SVG.
Attachment #779390 -
Flags: review?(kate)
Flags: needinfo?(kate)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 779391 [details] [review] https://github.com/mozilla/login.webmaker.org/pull/133 Not needed.
Attachment #779391 -
Attachment is obsolete: true
Attachment #779391 -
Flags: review?(kate)
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 779390 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/126 Looks good now
Attachment #779390 -
Flags: review?(kate) → review+
|
||
Comment 7•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/843470a665a8c618546f93c35199aabb02be89af Bug 896500 - Merge old userbar into header bar in prep for new UI
|
|
||
Comment 8•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/8e886dc7008089445fc354877afb3af2eb7458e5 Revert "Bug 896500 - Merge old userbar into header bar in prep for new UI" This reverts commit 843470a665a8c618546f93c35199aabb02be89af.
|
|
Assignee | |
Comment 9•11 years ago
|
||
We missed something somewhat important in the interim, so I need to revert that out. https://github.com/mozilla/popcorn.webmaker.org/commit/8e886dc7008089445fc354877afb3af2eb7458e5
|
|
||
Comment 10•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/320a80dc7c80d1ab9c2ca5ffc8a7157746b239c8 Bug 896500 - Merge old userbar into header bar in prep for new UI
|
|
Assignee | |
Comment 11•11 years ago
|
||
We are good now!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•