897088 - [Clock] Modules incorrectly organized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Mike Pennisi [:jugglinmike]]

Currently, the 'alarm.js' file contains two singletons: ClockView and AlarmList. These definitions should be made in separate files that accurately reflect their contents.

Comment 1

[Mike Pennisi [:jugglinmike]]

Attachment: Improve module organization

Hey Ian,

I'm not sure how you prefer to conduct code reviews, so I've also made a pull request on GitHub; you can find it here: https://github.com/mozilla-b2g/gaia/pull/11126

Comment 2

[[e-mail], [e-mail]]

(In reply to Mike Pennisi [:jugglinmike] from comment #1)
> Created attachment 779833 [details] [diff] [review]
> Improve module organization
> 
> Hey Ian,
> 
> I'm not sure how you prefer to conduct code reviews, so I've also made a
> pull request on GitHub; you can find it here:
> https://github.com/mozilla-b2g/gaia/pull/11126

Hi Mike,

The reviewing process is okay for me. One bug for one request(pull request). And we can address discussion on Github if we need to do so.

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 779833 [details] [diff] [review]
Improve module organization

Review of attachment 779833 [details] [diff] [review]:
-----------------------------------------------------------------

The patch works for me. It will help to organise the two modules. Thanks.

Comment 4

[Mike Pennisi [:jugglinmike]]

Landed on `master` with commit fb26423d9aadf53c3f9278b228791e52e8af4364

Thanks for the review, Ian!