897089 - [Clock] Utility methods pollute global scope

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Mike Pennisi [:jugglinmike]]

All utility methods are currently declared on the global scope. Organizing utility methods under a single namespace increases code readability and minimizes global namespace pollution.

Comment 1

[Mike Pennisi [:jugglinmike]]

Attachment: Bug-897089-util-methods.patch

Hey Ian,

I'm not sure how you prefer to conduct code reviews, so I've also made a pull request on GitHub; you can find it here: https://github.com/mozilla-b2g/gaia/pull/11127

Comment 2

[[e-mail], [e-mail]]

Comment on attachment 779839 [details] [diff] [review]
Bug-897089-util-methods.patch

Review of attachment 779839 [details] [diff] [review]:
-----------------------------------------------------------------

Mike,

I leave a comment on Github. Beside of a nit, the patch works for me.
Please revise and set the review again. Then, I'll help you to take a look.
Thank you.

Comment 3

[Mike Pennisi [:jugglinmike]]

Attachment: Bug-897089-util-methods-v2.patch

Nice catch, Ian! I've incorporated your feedback (see attached). I've also pushed this new commit to the pull request on GitHub.

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 782609 [details] [diff] [review]
Bug-897089-util-methods-v2.patch

Review of attachment 782609 [details] [diff] [review]:
-----------------------------------------------------------------

Mike,

Looks fine. Thanks for your updated.

Comment 5

[Mike Pennisi [:jugglinmike]]

Landed in `master` at commit 495b889386d02112aca9dc13fe2b8f14477406e6

Thanks for the review, Ian!