Closed
Bug 897409
Opened 11 years ago
Closed 11 years ago
canvas doesn't render in metrofx nightly
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jimm, Assigned: nrc)
References
()
Details
Attachments
(1 file, 1 obsolete file)
4.97 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
This seems to run, but doesn't display anything on the canvas surface. Probably omtc related. It would be good to have this working so we can run the tscanvasmark talos test. Marking this as blocking bug 773817 to track however we don't have to wait on this to get a base set of tests going in talos.
Reporter | ||
Updated•11 years ago
|
Blocks: metro-talos
Reporter | ||
Comment 1•11 years ago
|
||
Looking at various canvas demos on the web, nothing seems to render. Switching product/component.
Component: Browser → Canvas: 2D
Product: Firefox for Metro → Core
Reporter | ||
Updated•11 years ago
|
Summary: canvasmark doesn't render in metrofx nightly → canvas doesn't render in metrofx nightly
Assignee | ||
Comment 2•11 years ago
|
||
I'm working on d3d11 OMTC at the moment. I'll look at canvas tomorrow.
Blocks: 756606
Assignee | ||
Comment 3•11 years ago
|
||
The first patch in bug 895116 breaks all 2d canvas rendering for Windows OMTC (d3d9 and 11).
Assignee: nobody → ncameron
Component: Canvas: 2D → Graphics: Layers
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Nick Cameron [:nrc] from comment #3) > The first patch in bug 895116 breaks all 2d canvas rendering for Windows > OMTC (d3d9 and 11). We have a simple 2d canvas ripples demo in our tests that works, fwiw - http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/tests/mochiperf/res/ripples.html?force=1
Updated•11 years ago
|
No longer blocks: metrov1defect&change
Assignee | ||
Comment 5•11 years ago
|
||
This fixes the problem, but I haven't been able to test the basic compositor to ensure that canvases still work. dzbarsky has agreed to test it for me - thanks!
Attachment #781431 -
Flags: feedback?(dzbarsky)
Comment 6•11 years ago
|
||
Comment on attachment 781431 [details] [diff] [review] use a temporary surface rather than forcing an image surface for canvas Review of attachment 781431 [details] [diff] [review]: ----------------------------------------------------------------- Ship it!
Attachment #781431 -
Flags: feedback?(dzbarsky) → feedback+
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 781431 [details] [diff] [review] use a temporary surface rather than forcing an image surface for canvas thanks for testing dzbarsky!
Attachment #781431 -
Flags: review?(matt.woodrow)
Comment 8•11 years ago
|
||
Comment on attachment 781431 [details] [diff] [review] use a temporary surface rather than forcing an image surface for canvas Review of attachment 781431 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/CopyableCanvasLayer.cpp @@ +89,5 @@ > ? gfxASurface::ImageFormatRGB24 > : gfxASurface::ImageFormatARGB32; > > + bool needsTempSurface = !aDestSurface || > + aDestSurface->GetType() != gfxASurface::SurfaceTypeImage; Call GetAsImageSurface on aDestSurface and check if that returns nullptr, rather than checking the type of aDestSurface.
Attachment #781431 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6846b610be41
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6846b610be41
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Assignee | ||
Comment 11•11 years ago
|
||
This was backed out for suspicion of causing increased frequency of bug 895873: https://hg.mozilla.org/integration/mozilla-inbound/rev/7656ce2cd329
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 12•11 years ago
|
||
I also think it doesn't work, or at least only works for main thread compositing and, for reasons I don't understand, for the basic compositor.
Assignee | ||
Comment 13•11 years ago
|
||
Comment on attachment 781431 [details] [diff] [review] use a temporary surface rather than forcing an image surface for canvas Review of attachment 781431 [details] [diff] [review]: ----------------------------------------------------------------- I which I drive by r- my own patch... ::: gfx/layers/CopyableCanvasLayer.cpp @@ +158,1 @@ > mSurface = resultSurf; This looks like it will only work in the MTC case where we use mSurface for painting. For OMTC, we should update aDestSurface from resultSurf. I don't know why this works with the basic compositor.
Comment 14•11 years ago
|
||
I was going to wait to mark this until it was confirmed to be the cause. Unfortunately, the orange persists :( Anyway, sounds like you have other reasons for wanting it out at this point, so I won't re-land it in the mean time.
Target Milestone: mozilla25 → ---
Assignee | ||
Comment 15•11 years ago
|
||
Attachment #781431 -
Attachment is obsolete: true
Attachment #783577 -
Flags: review?(matt.woodrow)
Comment 16•11 years ago
|
||
(In reply to Nick Cameron [:nrc] from comment #11) > This was backed out for suspicion of causing increased frequency of bug > 895873: > > https://hg.mozilla.org/integration/mozilla-inbound/rev/7656ce2cd329 Merge of backout: https://hg.mozilla.org/mozilla-central/rev/7656ce2cd329
Updated•11 years ago
|
Attachment #783577 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 17•11 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=7015fe647196
Assignee | ||
Comment 18•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/88919d816c32
Comment 19•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/88919d816c32
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Reporter | ||
Comment 20•11 years ago
|
||
CanvasMark is running great, thanks!
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•