897722 - Put privacy control _under_ the field it modifies.

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: Screen Shot 2013-07-24 at 4.46.47 PM.png

In narrow screens, the privacy control field on profile edit/create is above the field it modifies. This makes the layout hard to understand. We should put the privacy control below the field it modifies.

Suggestion: Use source order to accomplish this. That semantically implies the relationship that we're trying to express visually.

Screenshot attached.

Comment 1

[Julia Elman]

Pull request submitted here: https://github.com/mozilla/mozillians/pull/655

Comment 2

[Julia Elman]

(In reply to Justin Crawford [:hoosteeno] from comment #0)

> Suggestion: Use source order to accomplish this. That semantically implies
> the relationship that we're trying to express visually.

Hi Justin! Not sure if you are referring to the new flex order CSS property in this comment or something else. If you are referring to flex order property, I opted out of using that for this fix since it is not well supported (especially on mobile) yet. See this link for reference https://developer.mozilla.org/en-US/docs/Web/CSS/order

Please let me know if you were referring to something else entirely and I'll be happy to re-adjust the code! :D

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/8e62a6d49475d54adbab6d5e12715b5da7228c00
[Fix Bug 897722] Position privacy select dropdowns below input fields.

https://github.com/mozilla/mozillians/commit/5df9bae9f2124401e38583c6c76d23341b3441ed
Merge pull request #655 from juliaelman/897722-fix-privacy-field-placement

[Fix Bug 897722] Position privacy select dropdowns below input fields.

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Privacy under the field it modified indeed!