897736 - Content Crash occurs when going to the settings -> About Firefox in the Browser

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

## Environment :
"mozilla-central" revision="2983ca6d4d1a"
"gecko.git" "9a1a3a0658790de7f95e0ab4a18ba78f71266b96"/>
"gaia.git" revision="5aac3408cdefed4afb1b14d57a69d713c69b46b9"
Build ID: 2013-07-24-03-02-03
MC/master build
Unagi

STR:
1. launch browser
2. open the tab tray
3. select the settings icon
4. select about firefox

Expected: about firefox page
Actual: content crash.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Marking as qablocker as I can't get into the about firefox pages and blocks all tests in regards to checking urls, etc. within this part of the browser app.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

I'm not seeing this on the peak

Comment 3

[ffos-browser]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/54397542

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

2013-07-17-03-02-08 : no content crash; crashes when you select about firefox -> FAQ ; [ https://crash-stats.mozilla.com/report/index/cd76acb5-50f9-48d9-9358-e37ee2130801 ] 
"gecko" revision="582ffcd0459a"
gecko revision="efe1f9ee0048f26be057f728f8aefb85a39d3683"
gaia revision="f8740f5cd78f44a1063463cd96794f124c5b754e"

2013-07-18-03-02-09 : has the content crash
"gecko" revision="f26e4c26ce4a
"gecko.git" revision="cb9a271064cc2dda511972f4720b33f2ff0188b3"
gaia revision="4ec7c428f6a63a44f888ea6f6ade0385c89ae305"

Comment 5

[Dale Harvey (:daleharvey)]

E/GeckoConsole( 1639): [JavaScript Error: "No settings permission for: app://browser.gaiamobile.org" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsManager.js" line: 369}]
I/Gecko   (  734): Security problem: Content process does not have `settings-read'.  It will be killed.
E/GeckoConsole(  734): [JavaScript Error: "msg is null" {file: "resource://gre/modules/SettingsChangeNotifier.jsm" line: 100}]
I/Gecko   (  734):
I/Gecko   (  734): ###!!! [Parent][AsyncChannel] Error: Channel error: cannot send/recv

Its crashing because it needs access to the settings permission, we are attempting to show the about screen within an iframe which does not have these permissions, need to move the about page to be showed within the browser app
I/Gecko   (  734):
I/Gecko   (  734): [Parent 734] WARNING: waitpid failed pid:1639 errno:10: file ../../../gecko/ipc/chromium/src/base/process_util_posix.cc, line 260
D/memalloc(  734): /dev/pmem: Freeing buffer base:0x49886000 size:532480 offset:1228800 fd:132

Comment 6

[Dale Harvey (:daleharvey)]

So the UI for the about pages are very much based around being inside content, its possible to fake this but its not going to be very nice, the back button / navigation to other content etc

about:credits does work inside the firefox browser, about: doesnt

How do about pages work in android? I dont think we can give frames escalated privileges

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

about: pages have chrome privs in both android and desktop. That would seem to be a thing we'll want to solve.

In the mean time, attempting to access something when you don't have the appropriate privs should through an exception, but not crash the process. Fixing that (and perhaps having about:firefox handle the exception reasonably) would seem to be the thing to take care of in this bug. Please file another bug for making about: pages have chrome privs though.

Comment 8

[Dale Harvey (:daleharvey)]

So a few things

The 'about page' is not an about: page, its just plain web content served from the browser app, Will open a seperate bug for implementing this as proper about: page (at which point it may / may not have the correct privs)

The standard behaviour is to just have a null error when the content process does not have the correct privileges, the same code served in web content will just give a 'mozsettings is null' error, however since it is served from the app origin I think it gets treated as an app, the app checked killing a process for unauthed access seems like it probably behaves that way for a good reason.

It may not be possible to treat app origined content as web content here, if so the about: fix would be the only fix, checking that now.

Comment 9

[Dale Harvey (:daleharvey)]

and just as I say that, this bug has been fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=898512

I have filed a new bug to have the about page fixed properly https://bugzilla.mozilla.org/show_bug.cgi?id=903690

Comment 10

[Dale Harvey (:daleharvey)]

Hey Brad, this is the type of bug I think its safe for us to accept ourselves in pivotal, but just want to check.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

yes, you can accept this yourself

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
"gecko" revision="8c240c67f76c"
"gecko" revision="4dd254baf424523d3256ae47bdc20f9b2b8d5217"
"gaia" revision="b527d7406b4eed3bacdee78597bb4ff21bf9f7d0"
Build ID: 2013-08-13-04-02-22
MC/master build
Unagi