Closed Bug 897817 Opened 11 years ago Closed 6 years ago

B2G MMS: Change gMmsConnection into an interface based object.

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ctai, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently, gMmsConnection is an object in MmsService.js and don't have a good network manager yet. We should create an interface for all the connection functions for MMS. That will provide more flexible way for different connection logic. For example, we can replace the original MMS connection with test-based connection.
Attached patch bug-897817.patch-v1.0 (obsolete) — Splinter Review
Attachment #782370 - Flags: feedback?(vyang)
Comment on attachment 782370 [details] [diff] [review]
bug-897817.patch-v1.0

I think that's only an option, not something necessary for now.  We can re-examine the necessity when we have a working MMS test framework.  Shall we?
Attachment #782370 - Flags: feedback?(vyang)
Per talk with vyang, we need this for MMS test framework.
Attachment #782370 - Attachment is obsolete: true
Attachment #812955 - Flags: feedback?(vyang)
Comment on attachment 812955 [details] [diff] [review]
bug-897817.patch v1.1

Review of attachment 812955 [details] [diff] [review]:
-----------------------------------------------------------------

Let's keep it in |MmsService.js| first, so that we don't install new components.
Attachment #812955 - Flags: feedback?(vyang)
Component: DOM: Device Interfaces → RIL
Product: Core → Firefox OS
Assignee: ctai → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: