89791 - if-else cascade cleanup

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect, P1)

Description

[Ulrich Drepper]

I came across this while reading the code.  The nsTextFrame::Paint function
currently contains a mess of if-else cases to decide whether PaintUnicodeText or
PaintAsciiText has to be used.  This mess cannot be cleaned up automatically by
the compiler (at least gcc cannot do it).  I'll attach a patch now which cleans
this code up and makes it IMO much more readable.  It saves 76 bytes on x86 :-).

Comment 1

[Ulrich Drepper]

Attachment: if-else cascade cleanup

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I guess I'll try to get this in.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Am I missing something amid the convoluted logic here or did you remove the test
of |(hints & NS_RENDERING_HINT_FAST_8BIT_TEXT)|?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: better patch? (still respects hint from RC)

Comment 5

[Chris Waterson]

r/sr=waterson

Comment 6

[jag (Peter Annema)]

Yep, that's what I ended up with after merging the if clauses.

r=jag

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-07-31 20:10 PDT.

Comment 8

[Chris Petersen]

Since I 'm not exactly sure how to test this, I'm marking verified based on the
last comments.