898311 - #error qmetatype.h must be included before any header file that defines Bool

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tatiana Meshkova (:tatiana)]

Qt Firefox fails to build:

c++ -o PluginModuleParent.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /home/nebel/mozilla-upstream/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL  -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -DFORCE_PR_LOG -I/home/nebel/mozilla-upstream/dom/plugins/ipc/../base -I/home/nebel/mozilla-upstream/xpcom/base/  -I/home/nebel/mozilla-upstream/ipc/chromium/src -I/home/nebel/mozilla-upstream/ipc/glue -I../../../ipc/ipdl/_ipdlheaders  -I/home/nebel/mozilla-upstream/dom/plugins/ipc -I. -I../../../dist/include  -I/home/nebel/mozilla-upstream/obj-browser-qt-debug/dist/include/nspr -I/home/nebel/mozilla-upstream/obj-browser-qt-debug/dist/include/nss      -fPIC  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe  -DDEBUG -D_DEBUG -DTRACING -g -Os -freorder-blocks  -fno-omit-frame-pointer   -I/usr/include/qt5/QtGui -I/usr/include/qt5 -I/usr/include/qt5/QtCore -I/usr/include/qt5/QtNetwork -I/usr/include/qt5/QtOpenGL -I/usr/include/qt5/QtWidgets -I/usr/include/qt5/QtPrintSupport   -I/usr/include/qt5/QtGui/5.0.2/QtGui -I/home/nebel/mozilla-upstream/obj-browser-qt-debug/dist/include/cairo   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/PluginModuleParent.o.pp  /home/nebel/mozilla-upstream/dom/plugins/ipc/PluginModuleParent.cpp
In file included from /usr/include/qt5/QtCore/qobject.h:55:0,
                 from /usr/include/qt5/QtCore/qcoreapplication.h:45,
                 from /usr/include/qt5/QtCore/QCoreApplication:1,
                 from /home/nebel/mozilla-upstream/dom/plugins/ipc/PluginModuleParent.cpp:43:
/usr/include/qt5/QtCore/qmetatype.h:56:2: error: #error qmetatype.h must be included before any header file that defines Bool
/usr/include/qt5/QtCore/qmetatype.h:205:9: error: expected identifier before ‘int’
...

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Ugh. Do you know what defines Bool?

Comment 2

[Tatiana Meshkova (:tatiana)]

Xlib.h included from npapi.h defines Bool. These four include npapi.h:

#include "mozilla/plugins/PluginModuleParent.h"
#include "mozilla/plugins/BrowserStreamParent.h"
#include "nsNPAPIPlugin.h"
#include "PluginIdentifierParent.h"

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Can you check if this helps?

Comment 4

[Tatiana Meshkova (:tatiana)]

Attachment: build log

Comment 5

[Tatiana Meshkova (:tatiana)]

Attachment: qmetatype.h

Comment 6

[Tatiana Meshkova (:tatiana)]

Comment on attachment 782486 [details] [diff] [review]
Patch v1

It doesn't. See the log above.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

I hate C++. How about this?

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yes, I'll land it, thanks for the reminders.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f307c0643e69

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f307c0643e69