898384 - Unable to update makes via makeapi.webmaker.org

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[inactivate account for kate]

Yesterday evening Kat was reporting a bug on makeapi.webmaker.org the she was unable to update makes via the /admin interface.

STR:
- Login to makeapi.webmaker.org, got to /admin
- Try editing a make (add a tag, webmaker:test-1 for example)
- Refresh page
Expected:
- Make is updated with new take
Actual
- On page refesh, make reverts to original state.

No console errors - this was happening on Firefox and Chrome.

I could not reproduce locally/remotely with my own account.

Is this an LDAP probem? Something specific with Kat's account privileges? Any ideas?

Comment 1

[Chris DeCairos (:cade)]

The problem here was that we neglected to update the update function for wrapped makes in makeapi-client. Patch incoming.

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/makeapi-client/pull/8

will have to land this, tag it, then create package.json updates to Popcorn Maker, Thimble and Webmaker. >.<

Comment 3

[Chris DeCairos (:cade)]

Critical because updating using the makeapi admin tool is broken on prod. Might affect thimble and popcorn makes as well.

Comment 4

[inactivate account for kate]

Comment on attachment 781683 [details] [review]
https://github.com/mozilla/makeapi-client/pull/8

Fixes the issue locally for me

Comment 5

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/120

MakeAPI update to makeapi-client v0.5.5

Comment 6

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/295

webmaker.org update to makeapi-client v0.5.5

Comment 7

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/185

Update thimble to makeapi-client v0.5.5

Comment 8

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/139

update Popcorn Make to makeapi-client v0.5.5

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/ff87864dcb56b1c321b5fc48ce843930e25fc6c7
Bug 898384 - update makeapi-client to v0.5.5

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/10f18e974c342d7eb30210afc5de5def3528201c
Bug 898384 - update makeapi-client to v0.5.5

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/1a17f529a288942abac0c08c7d356838ea3c19a7
Bug 898384 - update makeapi-client to v0.5.5

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/d3fb9c4551a82d411114c5eabdf0d077a5fac01b
Bug 898384 - update makeapi-client to v0.5.5

Comment 13

[Chris DeCairos (:cade)]

Fixes landed on Prod!