89854 - netscape 4.x profile migration dialog doesn't fit on 640x480 screen

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Christopher Blizzard (:blizzard)]

From Alan:

"Run netscape, quit, run mozilla for the first time on a 640x480 display and
the dialog is not all visible."

Does anyone feel like rogering that dialog so that it isn't long as hell?  It
should be cleaned up.

Comment 1

[Blake Ross]

This shouldn't be a special xul window at all, it just needs to be a regular 
prompt with special strings for the buttons.  This is thrown from the backend. 
-> backend

Comment 2

[Conrad Carlen (not reading bugmail)]

Fully agree. It should just be a nsIPromptService::ConfirmEx. How is it possible
with commonDialogs, which are used for that, to have the width of the static
text field fixed, the text flowed into it, and it would grow vertically. There's
all kinds of dialogs done in wallet where linebreaks are inserted in the
properties file to avoid the wide dialog. Whenever those things are localized,
these linebreaks have to be redone by hand. Can't we set up the XUL of
commonDialogs to avoid this?

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: patch to do dialog with nsIPromptService

Comment 4

[Conrad Carlen (not reading bugmail)]

Using nsIPromptService to do this makes the text wrap nicely so the fixed width
of the dialog. It also cleans up some odd logic in the back-end and another set
of .xul/.js files can be removed from the profile resources.

Comment 5

[Conrad Carlen (not reading bugmail)]

-> 0.9.4

Comment 6

[Conrad Carlen (not reading bugmail)]

Attachment: fixed patch to migration.properties

Comment 7

[Conrad Carlen (not reading bugmail)]

The first patch removed some things from migration.properties that it shouldn't
have.

Comment 8

[Conrad Carlen (not reading bugmail)]

Bhuvan - Can you r=? Ben or Blake sr=?

Comment 9

[racham]

looks good. r=racham.

Conrad, please do post a screen shot. thanks.

Comment 10

[Conrad Carlen (not reading bugmail)]

Attachment: screenshot of new dialog on 640 x 480 screen

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]

Comment 12

[Conrad Carlen (not reading bugmail)]

Attachment: slightly better patch

Comment 13

[Conrad Carlen (not reading bugmail)]

The slightly better patch uses unicode linefeed chars in the properties file
instead of using '#' chars an converting those to linefeeds in the C++.

Comment 14

[Conrad Carlen (not reading bugmail)]

Fix checked in.

Comment 15

[Grace Bush]

verified in build 2001082808