Closed Bug 898744 Opened 11 years ago Closed 11 years ago

Intermittent browser_394759_basic.js | The closed window data was stored correctly | The window correctly restored the form - Got , expected pi != 0.14569592452146363

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 26
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Make browser_394759_basic.js wait for tab invalidation before closing the window (without white space changes)
4.37 KB, patch
Details | Diff | Splinter Review
Make browser_394759_basic.js wait for tab invalidation before closing the window
5.99 KB, patch
Yoric
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=25797731&tree=Fx-Team
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_394759_basic.js | The closed window data was stored correctly
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_394759_basic.js | The window correctly restored the form - Got , expected pi != 0.14569592452146363
Gavin, can you suggest someone who can look into this please?
Flags: needinfo?(gavin.sharp)
I can do it.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Flags: needinfo?(gavin.sharp)
The problem here is that the tab gets invalidated after loading but sometimes there might be a pending save that fires, collects data and puts the collected data into the cache. Thus when the test changes the textbox value and closes the window we don't re-collect data. The test needs to wait for the tab state be invalidated before closing the window.
I seized the chance to fix a few other oddities and attached a version of the same patch without any white space changes, should be a lot easier to read.
Attachment #790151 - Flags: review?(dteller)
Comment on attachment 790151 [details] [diff] [review]
Make browser_394759_basic.js wait for tab invalidation before closing the window

Review of attachment 790151 [details] [diff] [review]:
-----------------------------------------------------------------

Nice simplification, thanks.

::: browser/components/sessionstore/test/browser_394759_basic.js
@@ +1,4 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  

Could you take the opportunity to add a comment mentioning what this test is testing?

@@ +55,5 @@
> +        ++restoredTabs;
> +        info("Restored tab " + restoredTabs + "/" + expectedTabs);
> +        if (restoredTabs < expectedTabs) {
> +          return;
> +        }

If |restoredTabs > expectedTabs|, we should probably also fail and return.
Attachment #790151 - Flags: review?(dteller) → review+
https://hg.mozilla.org/mozilla-central/rev/cc07397c7ad4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Whoops, this never affected 24. Not sure why I thought it did. Caused some pretty nice bustage, though! Backed out.
https://hg.mozilla.org/releases/mozilla-beta/rev/f676984e6e04
status-firefox24: fixed → unaffected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: