898862 - Global search is displayed incorrectly (invisible) if gloda is disabled

Status: RESOLVED INVALID

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Martin Picek]

In the "Customize Toolbar" dialog, "Global Search" icon is invisible (the text is visible). If you drag it to your toolbar, the widget only occupies space but is invisible.

Comment 1

[WADA:World Anti-bad-Duping Agency]

Is "[ ? ] Eable Global Search and Indexer"(called Gloda) enabled(Checked) at Tools/Options(if Win), Advanced/General?

In Tb 17.0.7 on MS Win, following is observed.
      Customize ToolBar   Text              Icon
  Gloda is enabled  :      Global Search     Rectangle box is shown
  Gloda is disabled :      Global Search     nothing is shown

Global Search can be used only when Global Search Indexer is enabled.
If your problem is with Gloda disabld, I think phenomenon is;
  When Global Search and Indexer is disabled, Icon part is normally
  hidden, but Text part is not successfully hidden.

Comment 2

[:aceman]

Confirming what WADA says. Is that the problem reporter sees?
This would need thought whether we want to hide the element altogether if Indexing is disabled. If not, then it should not be hidden partly (icon hidden, text shown). Maybe we could draw it fully but with a disabled look so it is an indication it will do nothing when dragged to the toolbar? I talk about the appearance in the customize dialog only.

Comment 3

[Richard Marti (:Paenglab)]

I think instead of only collapsing the searchinput textbox, the gloda-item and the wrapper-gloda-item (to also hide the label and not using space in customizing window) should be collapsed. It makes no sense to show the gloda-item at all when Indexing is disabled and nothing can be done with it.

Comment 4

[:aceman]

That could work too, but it needs to test if an existing but collapsed element does not cause any problems in the customize dialog.

Comment 5

[Martin Picek]

I must confirm what WADA says: the problem was caused by the disabled indexer.

However, this behavior is VERY confusing. In my humble opinion, correct behavior is:

 1. If the indexer is enabled, standard icon and text is present in the "Customize Toolbar" dialog and standard widget appears on the toolbar.
 2. If the indexer is disabled, standard icon and text is present in the "Customize Toolbar" dialog BUT inactive (disabled) widget appears on the toolbar.

This solution avoids issues like "What to do when widget is already present on the toolbar and then the user disable the indexer? Remove the widget? Make it invisible?".

Comment 6

[WADA:World Anti-bad-Duping Agency]

(In reply to Martin Picek from comment #5)
> "What to do when widget is already present on the toolbar
> and then the user disable the indexer?
> Remove the widget? Make it invisible?".

Behaviour of T 17.0.7 on Win.
- "Global Search box" in Toolbar is hidded.
 - Nothing is shown in Customize Toolbar panel
i.e. Current behaviour is;
- Tb hides "Global Search" at any place, when Gloda is disabled.
- When "Global Search" is held in Customized Toolbar panel,
  Tb fails to hide Text part of "Global Search"
  when "Gloda is disabled.

This is perhaps following;
- Toolbar button is defined in;
    messenger/content/extraCustomizeItems.xul
      <toolbarpalette id="MailToolbarPalette">
        <toolbarbutton id="ABC" title="DEF" label="GHI" ... />
  This is shown at Customized Toolbar panel.
  Shown text is title="DEF" when placed in Customized Toolbar panel.
- By Toolbar customize, the button is moved to;
    global/content/customizeToolbar.xul
  Button is shown in Titlebar.
  Shown text is label="GHI" when placed in Toolbar.
- In both cases, used icon is defined by CSS rule for the button.
    toolbarbutton#ABC { list-style-image: url(" ...") }
- Enable/Disabe(Show/Hide) of button is done via ID of xul element.
- After Disable/Hide, title="DEF" part is shown if button is held in
  extraCustomizeItems.xul.
  This is perhaps because;
    "Global Search" was initially customizeToolbar.xul.
    After it, "Costomize Toolbar" is supported and "title" attribute is
    newly used by extraCustomizeItems.xul(Customized Toolbar panel).

Comment 7

[WADA:World Anti-bad-Duping Agency]

My previous guess seems inaccurate.

When Gloda is enabled and "Global Search" is placed and viewable at Customize Toolbar panel, disable "Global Search and Indexer".
In Customize Toolbar panel, toolbar pallette item was defined like next:
(checked by DOM Inspector)
> outer box :  toolbarpalletteitem id=wrapper-gloda-search
>   inner box #1 : Corresponds to Icon part
>         xul:hbox class=toolbarpalletteitembox
              toolbaritem id=gloda-search
>   inner box #2 : Corresponds to Text part
          xul:label (xbl:inherits="value=title", value="Global Search")

Phenomenon is perhaps following.
  Hide Global Search at Toolbar Pallette and Toolbar
  == Change element of "toolbaritem id=gloda-search" to invisible.
  So, xul:label part at Customize Toolbar panel is not hidden.

Comment 8

[WADA:World Anti-bad-Duping Agency]

(In reply to Martin Picek from comment #5)

I agree with you. Current behaviour is pretty confusing. I prefer following.
   When "Global Search and Indexer" is disabled by user,
   if Global Search" is already placed in Toolbar by user,
   move it back to Customize Toolbar panel from Toolbar.
   And, put "big red X" on Icon for "Global Search",
   gray out Text for "Global Search",
   do nothing upon Customize of "Global Search".

Comment 9

[Martin Picek]

(In reply to WADA from comment #8)

OK, I think this is acceptable.

But - what to do when the user enables the indexer again? Personally, I would only remove the "big red X" and wouldn't place the widget back on the toolbar.

Comment 10

[WADA:World Anti-bad-Duping Agency]

(In reply to Martin Picek from comment #9)
I agree with you. I also prefer it.

Comment 11

[Wayne Mery (:wsmwk)]

(In reply to Martin Picek from comment #9)
> (In reply to WADA from comment #8)
> 
> OK, I think this is acceptable.
> 
> But - what to do when the user enables the indexer again? Personally, I
> would only remove the "big red X" and wouldn't place the widget back on the
> toolbar.

I think this would be horrible. How then is user to know to put the widget back in toolbar?

Comment 12

[Wayne Mery (:wsmwk)]

With new unified toolbar bug 1811380 this should no longer be an issue.