Closed
Bug 898964
Opened 11 years ago
Closed 11 years ago
Exactly root the global JSObject*'s in testResolveRecursion
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
As it says on the tin, this adds tracing for |obj1| and |obj2|.
Attachment #782411 -
Flags: review?(sphink)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 782411 [details] [diff] [review] root_testResolveRecursion-v0.diff Review of attachment 782411 [details] [diff] [review]: ----------------------------------------------------------------- We probably don't do this anywhere else, but I'm thinking it might be a good idea to remove these roots at the end of the function, as defense against a future assertion that we don't have any lingering roots on shutdown. Sadly, this really ought to be done with the AutoObjectRooter that I killed, but I certainly don't want to resurrect that. I think we can live with a shutdown leak in the failure case.
Attachment #782411 -
Flags: review?(sphink) → review+
|
||
Updated•11 years ago
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/895d95fc58bb
https://hg.mozilla.org/mozilla-central/rev/895d95fc58bb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•