Closed
Bug 899440
Opened 11 years ago
Closed 11 years ago
Add a localization comment to contextmenu.search
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: flod, Assigned: ckitching)
References
Details
Attachments
(1 file)
|
1.39 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Bug 828254 added this string contextmenu.search=%S Search Please add a localization comment explaining what %S is. For example something like # LOCALIZATION NOTE (contextmenu.search): %S is the name of the search engine # used to search for the highlighted text
|
||
Comment 1•11 years ago
|
||
Sorry, flod, I should have caught that. Chris, let's make sure we land this before the Aurora merge.
Assignee: nobody → ckitching
|
Assignee | |
Comment 2•11 years ago
|
||
Eek! Sorry about that. Another convention learned...
Attachment #783370 -
Flags: review?(margaret.leibovic)
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 783370 [details] [diff] [review] localisationComment.patch Review of attachment 783370 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks! Not your fault, I should have caught this. Also, we should try to be better in general about adding localization notes.
Attachment #783370 -
Flags: review?(margaret.leibovic) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/eb6f884142fc
Flags: in-testsuite-
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eb6f884142fc
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•