899550 - [FIG] The url and the title text are overlapped on Gingerbread and lower devices

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Adrian Tamas (:AdrianT)]

Attachment: screenshot

LG Optimus 2X (Android 2.2)/ Samsung Galaxy R (Android 2.3)
Fig Nightly 2013-07-29

Steps to reproduce:
1) Open the app and tap on the URL bar
2) Enter any text in the url bar

Expected results:
The user can enter text

Actual results:
The text input field and the title bar are overlapped. This is not reproducible with the 2013-07-24 build but that build crashes

Comment 1

[Adrian Tamas (:AdrianT)]

Actually the build were the url is correctly displayed but the build crashes is 2013-07-26

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Disable editing mode animations on pre-Honeycomb devices

Comment 4

[Lucas Rocha (:lucasr)]

FYI: the equivalent animation is disabled in m-c. This patch simply applies the same behaviour on the new code.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 790167 [details] [diff] [review]
Disable editing mode animations on pre-Honeycomb devices

Review of attachment 790167 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. But why would be need to disable alpha animations on GB?

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #5)
> Comment on attachment 790167 [details] [diff] [review]
> Disable editing mode animations on pre-Honeycomb devices
> 
> Review of attachment 790167 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks good to me. But why would be need to disable alpha animations on
> GB?

Because the alpha animation is meant to run in sync with the animation to expand the URL bar. With this change, the URL bar simply snaps to the expanded size. So, the about:home UI should just snap on screen too.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/projects/fig/rev/5b87508c0148

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b87508c0148