Closed
Bug 899657
Opened 11 years ago
Closed 11 years ago
Account for duplicate sticky makes
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kate, Assigned: kate)
Details
Attachments
(1 file)
48 bytes,
patch
|
daleee
:
review+
|
Details | Diff | Splinter Review |
Right now if more than one make is tagged with a sticky prefix, e.g. two makes are tagged webmaker:test-1, one make will be omitted from the search (since the limit is 10). We should increase the limit of the search in case there are duplicates, and also show an error message in the editor.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #783240 -
Flags: review?(dale)
Comment 2•11 years ago
|
||
Comment on attachment 783240 [details] [diff] [review] https://github.com/mozilla/webmaker.org/pull/304 Looks fine to me. What happens with these errors though? Do we show them to the user? If so, are these errors something the user cares about / can see & do something about?
Attachment #783240 -
Flags: review?(dale) → review+
Comment 3•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/76ea12dc6f3366332d5b0a2325d696a5474ba308 Fix bug 899657: Account for duplicate sticky makes
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•