899682 - Blocklist UI must be more intelligent when asking for a restart

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Sachin Hosmani [:sachin]]

When an installed extension is detected as blocklisted after a blocklist update, a blocklist UI is shown. The blocklist UI contains two buttons "Restart Now" and "Restart Later".

If it is a hard block the add-on get disabled automatically. If a restart is not needed the user doesn't have to do anything. The restart buttons must be hidden.

If it is a soft block the user may choose to not to disable the add-on in which case also the restart buttons must be hidden.

Perhaps an "OK" button must be shown instead?

Cases of both hard and soft blocks and multiple add-ons would have to be dealt with similarly.

Comment 1

[Dave Townsend [:mossop]]

(In reply to Sachin Hosmani [:sachin] from comment #0)
> When an installed extension is detected as blocklisted after a blocklist
> update, a blocklist UI is shown. The blocklist UI contains two buttons
> "Restart Now" and "Restart Later".
> 
> If it is a hard block the add-on get disabled automatically. If a restart is
> not needed the user doesn't have to do anything. The restart buttons must be
> hidden.

A restart is always needed in this case

Comment 2

[Tony Mechelynck [:tonymec]]

(In reply to Dave Townsend (:Mossop) from comment #1)
[...]
> A restart is always needed in this case

Even for a restartless extension?

Comment 3

[Dave Townsend [:mossop]]

(In reply to Tony Mechelynck [:tonymec] from comment #2)
> (In reply to Dave Townsend (:Mossop) from comment #1)
> [...]
> > A restart is always needed in this case
> 
> Even for a restartless extension?

Disabling a restartless extension at runtime requires that we trust that the extension properly unloads and cleans up after itself. If an extension is known to be malicious or unstable then we can't trust it to do that, so yes even for a restartless extension we need to restart to be sure we've got rid of it.

Comment 4

[Sachin Hosmani [:sachin]]

So this bug would apply to only the other case I mentioned. The case when the UI consists of only softblocks and the user decides not to block any of them. I think a "Close" button would make sense there.

I could take this bug if we want it fixed.

Comment 5

[Andrew Swan [:aswan]]

Non-restartless extnesions and legacy extensions are no longer supported, which makes this irrelevant