899978 - Update socialshare widget on firefox OS page and add Facebook l10n helper

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect, P3)

Description

[Alex Gibson [:agibson]]

Now that the socialshare widget has been updated (b887147) we next need to update the widget on the Firefox OS page.

Facebook use different locale codes for their Like button SDK to the ones in bedrock. In order to make localization of the Like button easier, it has been proposed that we build a helper util that will automatically match the correct codes.

Comment 1

[Alex Gibson [:agibson]]

PR submitted here:

https://github.com/mozilla/bedrock/pull/1120/

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/382f10a3223e9c1581b60a2c68be65418db6913e
[bug 899978] Update social share widget for Firefox OS page

https://github.com/mozilla/bedrock/commit/ad0b1f67f4020a5f0d2f6c18211b4437fbe4a213
Merge pull request #1120 from alexgibson/update-social-share-widget-bug-887147

[bug 899978] Update socialshare widget for Firefox OS page and add Facebook l10n helper

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks good on https://www-dev.allizom.org/en-US/firefox/os/

Comment 4

[Boricua2013Jaquez]

[Tracking Requested - why for this release]:

Comment 5

[Boricua2013Jaquez]

https://bugzilla.mozilla.org/enter_bug.cgi?format=Facebook#h=[e-mail]|www.mozilla.org|