Closed
Bug 900179
Opened 11 years ago
Closed 11 years ago
[fig] Remove overdraws from child fragments in history panel
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: shilpanbhagat, Assigned: shilpanbhagat)
Details
(Whiteboard: fixed-fig)
Attachments
(1 file)
|
3.33 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
Child fragments in history panel currently draws a background which is not needed.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → sbhagat
OS: Mac OS X → Android
Hardware: x86 → ARM
|
|
Assignee | |
Comment 1•11 years ago
|
||
This patch removes the overdraw.
Attachment #783954 -
Flags: review?(sriram)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 783954 [details] [diff] [review] Patch: Removing overdraws from child fragments in history panel Review of attachment 783954 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. But why do we have an unnecessary LinearLayout in the last two XMLs? Wouldn't a home_list_view_with_title alone be enough?? File a separate bug and investigate.
Attachment #783954 -
Flags: review?(sriram) → review+
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1cc7d733d8c1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•