900361 - Enable customization per target device of resolution for FB images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Jose Manuel Cantera]

We need to add two parameters to communications_services.json in order to define a default base value for the resolution of the FB images to be shown both in contact list and contact details. The default value should be 120 and 200 respectively for not breaking inari / ikura devices.

For leo devices we will be talking to LG / TEF in order to finer tune this value according to the dpi provided by those devices. 

This should be marked as leo+ as per conversation with Daniel.

Comment 1

[Fernando Campo (:fcampo)]

Attachment: Lin kto PR - https://github.com/mozilla-b2g/gaia/pull/11295

Comment 2

[Wayne Chang [:wchang]]

Triage - can we understand what the user impact here is?
Does taking this bug provide better resolution pictures for contacts?
Is anything broken if we dont take this?

Thanks

Comment 3

[Jose Manuel Cantera]

Comment on attachment 784339 [details] [review]
Lin kto PR - https://github.com/mozilla-b2g/gaia/pull/11295

provided the latest nits are fixed. 

thanks!

Comment 4

[Jose Manuel Cantera]

(In reply to Wayne Chang [:wchang] from comment #2)
> Triage - can we understand what the user impact here is?
> Does taking this bug provide better resolution pictures for contacts?

Yes, particularly in leo devices we have found that default values are not enough, so the idea is to allow OEM / partners to customize these values. 

> Is anything broken if we dont take this?

Nothing, but a bad UX and bad user perception of the product

> 
> Thanks

Comment 5

[Fernando Campo (:fcampo)]

Merged on master https://github.com/mozilla-b2g/gaia/commit/4b347e4e39b1716b68463dccc63c1b3eb49158b3

waiting for the leo+ for setting the uplift flag

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Go ahead with uplift to v1.1

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 4b347e4e39b1716b68463dccc63c1b3eb49158b3
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 8

[Fernando Campo (:fcampo)]

uplifted 4c1a205

Thanks to all

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 4c1a20570e20f64782ba170c14604395c48f7381