900377 - the BMO push script shouldn't deploy if checksetup.pl failed

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Infrastructure, defect)

Description

[:glob ✱]

the BMO push script shouldn't deploy if checksetup.pl failed.

Comment 1

[Kendall Libby [:fubar] (he/him)]

Attaching a simple patch that should fix this; gogo pipefail.

Comment 2

[Kendall Libby [:fubar] (he/him)]

Attachment: exit on checksetup.pl error

Comment 3

[Shyam Mani [:fox2mike]]

Comment on attachment 784599 [details] [diff] [review]
exit on checksetup.pl error

Review of attachment 784599 [details] [diff] [review]:
-----------------------------------------------------------------

Looks straightforward enough. Do we want to unset pipefail (since that's the default). Want to make sure this won't cause unexpected fails elsewhere :)

Comment 4

[Kendall Libby [:fubar] (he/him)]

Since it's within the backticks (`...`) it only applies to that chain; that actually threw me off initially since it'd put it above in the main script and it wasn't having any effect.

Comment 5

[Shyam Mani [:fox2mike]]

(In reply to Kendall Libby [:fubar] from comment #4)
> Since it's within the backticks (`...`) it only applies to that chain; that
> actually threw me off initially since it'd put it above in the main script
> and it wasn't having any effect.

Those brackets are evil. I totally missed them too...

Comment 6

[Kendall Libby [:fubar] (he/him)]

As it happens, the prod script is slightly different than stage/dev and doesn't use backticks, so I added in an unset pipefail; the rest is the same. Committed in r72366.