900549 - install gcc 4.7.3 for testing purposes

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nathan Froyd [:froydnj]]

I'm seeing some GCC 4.7-specific breakage on several try pushes:

https://tbpl.mozilla.org/?tree=Try&rev=6c805cfe771b

I'm not seeing the same breakage on my home Debian box (which runs a patched version of GCC 4.7.2).

Looking at the patches for the Debian package and the changes made between GCC 4.7.2 and 4.7.3, there've been a number of C++-specific fixes, including at least one fix that's in both Debian and GCC 4.7.3 that plausibly looks like it might fix the Fedora crashes in that Try push above.  Fixing the Android crash is another story; hopefully the GCC 4.7 upgrade on android going on elsewhere will fix that bug.

Therefore, I'd like to get 4.7.3 installed--at least for testing purposes--and if that fixes compiler crashes, then we can upgrade to that.  Might also address some of the intermittent Linux PGO failures we've been seeing?

Comment 1

[Nathan Froyd [:froydnj]]

Rail, glandium mentioned that you might be a good person to build and upload GCC 4.7.3 RPMs?

Comment 2

[Rail Aliiev [:rail]]

Sure, I'll take care of it.

Comment 3

[Rail Aliiev [:rail]]

Attachment: [WIP] gcc 4.7.3 spec

Comment 4

[Rail Aliiev [:rail]]

Attachment: [WIP] gcc 4.7.3 spec

s/2010/2013

Comment 5

[Rail Aliiev [:rail]]

Nathan, we want these packages on try, correct?

Comment 6

[Nathan Froyd [:froydnj]]

(In reply to Rail Aliiev [:rail] from comment #5)
> Nathan, we want these packages on try, correct?

Assuming you mean "we want to be able to push to try and select these packages with appropriate mozconfig tweaks", then yes.  Is that what you mean?

Comment 7

[Rail Aliiev [:rail]]

Yeah, exactly what I meant.

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 784478 [details] [diff] [review]
[WIP] gcc 4.7.3 spec

Nathan, besides gcc, I bumped mpfr and gmp version. Do you feel comfortable with this change?

Comment 9

[Nathan Froyd [:froydnj]]

Comment on attachment 784478 [details] [diff] [review]
[WIP] gcc 4.7.3 spec

Review of attachment 784478 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine.

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 784478 [details] [diff] [review]
[WIP] gcc 4.7.3 spec

https://hg.mozilla.org/build/rpm-sources/rev/73c170662308

Comment 11

[Rail Aliiev [:rail]]

Attachment: gcc.diff

Install gcc 4.7.3 in parallel with 4.7.2.

Comment 12

[Hal Wine [:hwine] use NI!]

Comment on attachment 784563 [details] [diff] [review]
gcc.diff

Review of attachment 784563 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm -- per rail no request for change in thunderbird configs

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 784563 [details] [diff] [review]
gcc.diff

https://hg.mozilla.org/build/buildbot-configs/rev/f8803a3c1c53

The package will be available after next reconfig (Tue). Let me know if you need it ASAP, so I reconfig earlier.

Comment 14

[Nathan Froyd [:froydnj]]

(In reply to Rail Aliiev [:rail] from comment #13)
> The package will be available after next reconfig (Tue). Let me know if you
> need it ASAP, so I reconfig earlier.

Sounds good.  Thanks for the quick turnaround!

Comment 15

[Justin Wood (:Callek)]

in production

Comment 16

[Mark Banner (:standard8)]

Attachment: gcc additions for Thunderbird

The previous patch didn't add the gcc update for Thunderbird.

Comment 17

[Mark Banner (:standard8)]

Comment on attachment 788852 [details] [diff] [review]
gcc additions for Thunderbird

https://hg.mozilla.org/build/buildbot-configs/rev/3f4f03cc48e6

Comment 18

[Chris Cooper [:coop] (he/him)]

In production.