Closed
Bug 900647
Opened 11 years ago
Closed 5 years ago
Youtube embedded videos broken in templates
Categories
(support.mozilla.org :: Knowledge Base Software, task, P4)
support.mozilla.org
Knowledge Base Software
Tracking
(Not tracked)
RESOLVED
WONTFIX
Future
People
(Reporter: Noah, Unassigned)
Details
(Keywords: regression, Whiteboard: u=user c=wiki p=3 s=2013.backlog)
A recent Youtube iframe security bugfix broke embedded Youtube videos in templates. The video from this template: https://support.mozilla.org/en-US/kb/templatewuws Doesn't work in the article that uses that template: https://support.mozilla.org/en-US/kb/contributor-news-resources In the KB article under "Meeting Video", it just shows the raw iframe code. <iframe allowfullscreen="" frameborder="0" src="//www.youtube.com/embed/SdiU3bguhSM?wmode=transparent&rel=0&modestbranding=1"></iframe> This was caused by Bug 898769.
Comment 1•11 years ago
|
||
This broke with the fix to bug 898769. Some older related bugs: bug 854554 bug 862120 The issue is that Templates converted into HTML and inserted into the article that includes them before the final HTML sanitization done by bleack.clean(). bleach.clean() kills any iframes that are in the HTML at that point.
Whiteboard: u=user c=wiki p= s=2013.15
Updated•11 years ago
|
Keywords: regression
Target Milestone: --- → 2013Q3
Comment 2•11 years ago
|
||
Putting in the next sprint for somebody to look at.
Whiteboard: u=user c=wiki p= s=2013.15 → u=user c=wiki p= s=2013.16
Comment 3•11 years ago
|
||
Making this a P1 because it's a regression. :verdi, are there a lot of articles that depend on this? I don't know how many points this is going to take at this point. Assigning it 3 for now to make sure we block enough time in the sprint. We can adjust after some research.
Priority: -- → P1
Whiteboard: u=user c=wiki p= s=2013.16 → u=user c=wiki p=3 s=2013.16
Comment 4•11 years ago
|
||
This should not be a P1. The only place that I know for sure that this is used is on this contributor page - https://support.mozilla.org/en-US/kb/contributor-news-resources I believe that all KB articles that have videos do not have the videos in a template. This feature being broken is an annoyance but I don't believe it impacts users at all.
Comment 6•11 years ago
|
||
Pushing along to the next sprint given the lower priority and too much already in .16
Whiteboard: u=user c=wiki p=3 s=2013.16 → u=user c=wiki p=3 s=2013.17
Comment 7•11 years ago
|
||
moving to the backlog given the low priority
Whiteboard: u=user c=wiki p=3 s=2013.17 → u=user c=wiki p=3 s=2013.backlog
Comment 8•11 years ago
|
||
Let's try this again next sprint.
Whiteboard: u=user c=wiki p=3 s=2013.backlog → u=user c=wiki p=3 s=2013.18
Comment 9•11 years ago
|
||
This isn't going to be trivial to fix. I'd like to focus 2013.18 on Open Badges and Persona.
Whiteboard: u=user c=wiki p=3 s=2013.18 → u=user c=wiki p=3 s=2013.backlog
Comment 11•10 years ago
|
||
Moving 2013Q4 bugs to the Future since we didnt care enough about them in 2014Q1.
Target Milestone: 2013Q4 → Future
Updated•7 years ago
|
Priority: P3 → P4
Comment 12•5 years ago
|
||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•