Closed
Bug 900692
Opened 11 years ago
Closed 10 years ago
Add paint flashing preference to Settings > Developer tools
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(relnote-firefox 33+)
RESOLVED
FIXED
Firefox 33
Tracking | Status | |
---|---|---|
relnote-firefox | --- | 33+ |
People
(Reporter: liuche, Assigned: liuche)
References
Details
(Keywords: feature)
Attachments
(6 files, 1 obsolete file)
Paint flashing is controlled by nglayout.debug.paint_flashing. This can just be toggled on to enable paint flashing. This would go in Settings > Developer tools, probably below the Remote debugging/learn more items. Not sure what the right string for this would be: Paint flashing [] Show repainting Show repaints Show tile repaints
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #817519 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → liuche
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Comment on attachment 817519 [details] [diff] [review] Add paint flashing to Settings > Developer tools v1 Review of attachment 817519 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks good. But I wonder if we should add a description to the pref for extra clarity?
Attachment #817519 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Ian, any feedback on this? I'll see if I can add a short summary, something like "Flash tile repaints", "Show tile repaints as color flashing" (not sure about this, this might conflict with the Android style of updating the setting/preference summary to reflect the current state), or some other string.
Flags: needinfo?(ibarlow)
Assignee | ||
Comment 4•11 years ago
|
||
This is just some summary text I threw on. We could also make it disappear when the checkbox is unchecked, though that might be slightly less helpful for figuring out what "Paint flashing" is.
Comment 5•11 years ago
|
||
Additional info on what this feature does: https://developer.mozilla.org/en-US/docs/Tools/Paint_Flashing_Tool http://msujaws.wordpress.com/2012/02/01/layout-paint-flashing-in-firefox/
Comment 6•11 years ago
|
||
(In reply to Chenxia Liu [:liuche] from comment #4) > Created attachment 817996 [details] > Screenshot: summary text > > This is just some summary text I threw on. We could also make it disappear > when the checkbox is unchecked, though that might be slightly less helpful > for figuring out what "Paint flashing" is. As you know, I know little to nothing about these kinds of developer tools, so I guess my question for you would be, do developers understand what paint flashing is? Or is that a unique tool to Mozilla? I'm looking through the core suite of desktop developer tools and don't see any mention of paint flashing, which suggests to me that we may want to offer an easy path to more info -- maybe some way to link out to one or both of the articles Mark posted?
Flags: needinfo?(ibarlow)
Comment 7•11 years ago
|
||
Oh wait. I see it in the desktop dev tools now. Durr. Even still, I'm wondering if you feel it would be helpful to provide links out to more explanation?
Assignee | ||
Comment 8•11 years ago
|
||
I guess I just don't really like the way this looks - too much repetition? I'll try to come up with a reasonable way that we could make the doc link look different, without 1) having it looked forced and out of place, and 2) not repeating the dev tool title itself (like "Paint flashing" and "Paint flashing docs"). Any input is welcome!
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(ibarlow)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(ibarlow)
Comment 9•10 years ago
|
||
Might be worth a relnote, cool feature for developers.
relnote-firefox:
--- → ?
Keywords: feature
Comment 10•10 years ago
|
||
(In reply to Kevin Brosnan [:kbrosnan] from comment #9) > Might be worth a relnote, cool feature for developers. If it had actually landed. Which reminds me, maybe we should try to land this... I'd be OK with *not* using the "Learn more" for now and see how it is received with just the secondary text.
Comment 11•10 years ago
|
||
Please resubmit for the release notes once this bug is fixed. Thanks
relnote-firefox:
? → ---
Assignee | ||
Comment 13•10 years ago
|
||
Added tests because there weren't any for this section at all! (oops) https://tbpl.mozilla.org/?tree=Try&rev=479adfd3ea36
Attachment #8459015 -
Flags: review?(margaret.leibovic)
Assignee | ||
Updated•10 years ago
|
Attachment #817519 -
Attachment is obsolete: true
Comment on attachment 8459015 [details] [diff] [review] Part 2: Tests Review of attachment 8459015 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, assuming try is green.
Attachment #8459015 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 15•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/96ae5120fa66 https://hg.mozilla.org/integration/fx-team/rev/8c9fbda3a4e9
Target Milestone: --- → Firefox 33
Comment 16•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/96ae5120fa66 https://hg.mozilla.org/mozilla-central/rev/8c9fbda3a4e9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 18•10 years ago
|
||
Relnote: Paint flashing for browser content repaints can now be enabled from Settings.
Comment 19•10 years ago
|
||
Added with the wording "Developer tools: Paint flashing for browser content repaints". Sorry, we try to remain consistent and to avoid sentences.
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•