Closed
Bug 900776
Opened 11 years ago
Closed 11 years ago
Trace actor reports NaN time when exiting frames
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: rjacob, Assigned: rjacob)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.23 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
When exiting a frame, the trace actor reports that the time since the trace started is NaN. It should report the time in the same format as it does on frame entry (currently, milliseconds since tracing started).
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #784698 -
Flags: review?(nfitzgerald)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #784698 -
Flags: review?(nfitzgerald)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Whoops, generated the patch wrong.
Attachment #784698 -
Attachment is obsolete: true
Attachment #784702 -
Flags: review?(nfitzgerald)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 784702 [details] [diff] [review] exitTime.diff Review of attachment 784702 [details] [diff] [review]: ----------------------------------------------------------------- r+ with green try push[0] In the future, format your patches with 8 lines of context[1]. [0] https://wiki.mozilla.org/ReleaseEngineering/TryServer#How_to_push_to_try [1] https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Attachment #784702 -
Flags: review?(nfitzgerald) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=97c8bc7f176b
|
|
||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/24446c5f75c1
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/24446c5f75c1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•